Fix fallback to pkg-config when icu-config missing #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes building LTFS on Debian 11.
|
Actually, I don't expect any side effects because of this change. But I will accept this because build checker doesn't report any problem. But currently, we can't check the code except Linux. Let's see what happens in this chenge. |
|
Thanks. This should allow LTFS to build on Debian 11. I'm also working to try to get Debian 10 fixed so that the icu-config hack isn't needed: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=992591 |
Sounds nice! Thank you very much for your effort. |
veggiemike
pushed a commit
to veggiemike/ltfs
that referenced
this pull request
May 17, 2023
This fixes needs to build the LTFS on Debian 11 (cherry picked from commit 27e5ea1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes building LTFS on Debian 11.