Fix filehandle corruption on LP64 #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not take for granted that __WORDSIZE is defined to distinguish between 32 and 64 bit platforms. If undefined on LP64 machine, STRUCT_TO_FILEHANDLE corrupts the filehande. Instead use ULONG_MAX from <limits.h> which is mandated by ISO C99.
lucasvr
approved these changes
Mar 24, 2022
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Mar 24, 2022
This includes two fixes submitted upstream: LinearTapeFileSystem/ltfs#346 LinearTapeFileSystem/ltfs#345 While there, update the message about NetBSD requirement to drop informations about now unsupported releases, and require NetBSD >= 8.0
piste2750
approved these changes
Mar 25, 2022
|
Thank you for your patch. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not take for granted that __WORDSIZE is defined to distinguish between 32 and 64 bit platforms. If undefined on LP64 machine, STRUCT_TO_FILEHANDLE corrupts the filehande.
Instead use ULONG_MAX from <limits.h> which is mandated by ISO C99.