Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build break on FreeBSD 12 #396

Merged
merged 2 commits into from
May 22, 2024

Conversation

Krishhhnaa
Copy link
Contributor

@Krishhhnaa Krishhhnaa commented Apr 12, 2023

Summary of changes

This pull request includes following changes or fixes.

Description

there was error on line number 1247 about missing semicolon

Fixes #390

Type of change

Please delete items that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have confirmed my fix is effective or that my feature works

Copy link
Member

@piste-jp piste-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove the comment at the end of the line.

src/tape_drivers/freebsd/cam/cam_tc.c Outdated Show resolved Hide resolved
@juliocelon juliocelon requested a review from perezle April 17, 2023 17:57
Copy link

@perezle perezle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve

@piste-jp piste-jp changed the title issue #390 solved Fix the build break on FreeBSD 12 Jun 23, 2023
@piste-jp
Copy link
Member

@juliocelon ,

Please make a Squash and merge this into the master branch when new commit (removing unnecessary comment) is done.

@piste-jp piste-jp added the to master Merge to master branch label Jun 23, 2023
@piste-jp piste-jp self-requested a review May 22, 2024 09:36
Copy link
Member

@piste-jp piste-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the line by myself.

@piste-jp piste-jp assigned piste-jp and unassigned juliocelon May 22, 2024
@piste-jp piste-jp merged commit 102dcb4 into LinearTapeFileSystem:master May 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trying to compile latest git on freebsd 12.2 error missing ;
4 participants