Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jag7 fix #435

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Jag7 fix #435

merged 2 commits into from
Nov 27, 2023

Conversation

jgreen24
Copy link
Contributor

@jgreen24 jgreen24 commented Nov 21, 2023 •
edited
Loading

Summary of changes

This pull request includes following changes or fixes.

  • Removes backwards compatibility of the TS1170 tape drive

Description

  • Removes backwards compatibility of the TS1170 tape drive. Only JF tape cartridges may be used in the TS1170 tape drive, unlike previous generations.
    • For example, JM, JE and JV tapes may not be used in the TS1170 tape drive.

Type of change

Please delete items that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have confirmed my fix is effective or that my feature works

@jgreen24 jgreen24 self-assigned this Nov 21, 2023
juliocelon
juliocelon approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@juliocelon juliocelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Justin!!
It looks good to me.

piste-jp
piste-jp requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@piste-jp piste-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be writing category is wrong for UNKNOWN density code.

src/tape_drivers/ibm_tape.c Show resolved Hide resolved
perezle
perezle approved these changes Nov 27, 2023
View reviewed changes
Copy link

@perezle perezle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes.

@juliocelon juliocelon merged commit fd41c66 into LinearTapeFileSystem:v2.4-stable Nov 27, 2023
10 checks passed
juliocelon pushed a commit that referenced this pull request Nov 27, 2023
@jgreen24 @juliocelonibm
Jag7 fix (#435)
f36304e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocelon juliocelon juliocelon approved these changes

@piste-jp piste-jp piste-jp approved these changes

@perezle perezle perezle approved these changes

Assignees

@jgreen24 jgreen24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgreen24 @perezle @piste-jp @juliocelon