Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential use after free issues #462

Merged
merged 1 commit into from
May 23, 2024

Conversation

piste-jp
Copy link
Member

The problem was found by code scan. Use delete safe iteration instead.

Summary of changes

This pull request includes following changes or fixes.

Description

The CodeQL on the GitHub found three potential use after free issues. All are same flavor, it
means, use a pointer after free. So change the logic from normal iteration to delete safe iteration.

This fix might be good to merge to the v2.4-stable branch also.

Fixes #457

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have confirmed my fix is effective or that my feature works

The problem was found by code scan. Use delete safe iteration.
@piste-jp piste-jp requested a review from jgreen24 May 23, 2024 02:36
@piste-jp piste-jp self-assigned this May 23, 2024
@piste-jp piste-jp merged commit d19dfcf into LinearTapeFileSystem:master May 23, 2024
10 checks passed
@piste-jp piste-jp deleted the fix_sec branch May 23, 2024 11:45
juliocelon pushed a commit that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Potential use after free
1 participant