-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fhir-client] Document/support setting the fhirVersion mime-type parameter on requests #3256
Comments
It turns out we already support setting the default FHIR version from fhir-client. If needed, that can be a separate issue. |
and document how to set it via the `fhirclient.default.mimetype` configuration property (PROPNAME_DEFAULT_MIMETYPE) Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
and document how to set it via the `fhirclient.default.mimetype` configuration property (PROPNAME_DEFAULT_MIMETYPE) Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
issue #3256 - change the default fhirclient MIME type to specify fhirVersion 4.3
…type Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
issue #3256 added unit tests to support QA of FHIRClient default mime…
Confirmed that when setting
On the server side we see:
and when setting
It is noted that for Content-Type, the fhirVersion header value gets lower-cased to become |
Is your feature request related to a problem? Please describe.
From https://hl7.org/fhir/http.html#version-parameter
For R4B, via #3192 and #3242, we're gonna let this parameter drive server behavior, so we definitely need a way to set it from the client.
Describe the solution you'd like
Describe alternatives you've considered
Make it possible to set on a per-request basis
Acceptance Criteria
GIVEN a client with
fhirclient.default.mimetype = application/fhir+json; fhirVersion=4.0
WHEN the request is made to the server
THEN any applicable Accept or Content-Type header values have the fhirVersion mime type parameter set to 4.0
GIVEN a client with
fhirclient.default.mimetype = application/fhir+json; fhirVersion=4.3
(the default)WHEN the request is made to the server
THEN any applicable Accept or Content-Type header values have the fhirVersion mime type parameter set to 4.3
Additional context
The text was updated successfully, but these errors were encountered: