Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Make tests exit properly for mocha version >=4.x #896

Closed
Tschakki opened this issue Oct 24, 2017 · 0 comments
Closed

Make tests exit properly for mocha version >=4.x #896

Tschakki opened this issue Oct 24, 2017 · 0 comments
Assignees
@Tschakki

Comments

@Tschakki
Copy link
Contributor

Mocha is changing exit-behaviour after upgrade from 3.x to 4.x, see: https://mochajs.org/#--exit----no-exit

As a quickfix, the flag --exit should be set now when running mocha tests, to exit the process properly.
@Tschakki Tschakki mentioned this issue Oct 24, 2017
Merged
shuse2 added a commit that referenced this issue Apr 15, 2019
@shuse2
Merge pull request #986 from LiskHQ/p2p_jon
c9164dc 
Implement P2P.getNetworkStatus() functionality - Closes #985 and #897, addresses #896 and #953
shuse2 added a commit that referenced this issue Apr 15, 2019
@shuse2
Merge pull request #1012 from LiskHQ/896-event_handling
2294528 
Add receive data and handle response mechanism - Addresses #896
shuse2 added a commit that referenced this issue Apr 15, 2019
@shuse2
Merge pull request #1022 from LiskHQ/896-event_bubbling_and_response_…
d30ccc1 
…mechanism

Add receive data and handle response mechanism - Closes #896
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tschakki Tschakki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tschakki