Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add broadcast test for methods addFromPublic, addFromPeer, processPool #985

Closed
2 tasks
LucasIsasmendi opened this issue Nov 16, 2017 · 1 comment
Closed
2 tasks

Add broadcast test for methods addFromPublic, addFromPeer, processPool #985

LucasIsasmendi opened this issue Nov 16, 2017 · 1 comment
Labels
type: test

Comments

@LucasIsasmendi
Copy link
Contributor

Parent: #972

Boolean broadcast parameter included in addFromPublic and addFromPeer allows the processPool worker to send transactions to peers via bus message once it process all the pool lists.

Pending tasks:

  • Add tests to validate broadcast transactions
  • Check edge case when, at the same time, pool is cleaning the broadcast array and addFromPublic or addFromPeer are adding transactions to broadcast internal queue
@karmacoma karmacoma mentioned this issue Nov 16, 2017
Closed
@LucasIsasmendi
Copy link
Contributor Author

Closed by #1169

shuse2 added a commit that referenced this issue Apr 15, 2019
@shuse2
Merge pull request #986 from LiskHQ/p2p_jon
c9164dc 
Implement P2P.getNetworkStatus() functionality - Closes #985 and #897, addresses #896 and #953
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LucasIsasmendi