[BUG] Custom CSS styles not activating until 'type="text/css"' is added to corresponding link in HTML head

[shimizurei]

Environment

Self-Hosted (Docker)

Version

2.0.4

Describe the problem

I had finally gotten the CSS to not throw a 404, but for the life of me I could not get my styles to show up.

UNTIL I changed one thing (using devtools):

How the custom CSS loads in: <link rel="stylesheet" href="/assets/dashycsstweaks.css">

What I needed to do to activate my CSS: <link rel="stylesheet" type="text/css" href="/assets/dashycsstweaks.css">

I was previously upping the CSS specificity to disgusting levels to no avail:

div#dashy div.home[style*="background: url("/assets/wetpavement_bg.jpg") 0% 0% / cover"] {
  background-attachment: fixed !important;
}

Would it be possible to add the type="text/css" part to the generated link when the app is built?

Additional info

No response

Please tick the boxes

• You are using a supported version of Dashy (check the first two digits of the version number)
• You've checked that this issue hasn't already been raised
• You've checked the docs and troubleshooting guide
• You agree to the code of conduct

[Lissy93]

Yes, absolutely I can add that
Quick question, how are you specifying the stylesheet in your config?

[shimizurei]

Docker compose, under volumes: - /volume1/docker/dashy/assets/dashycsstweaks.css:/app/public/assets/dashycsstweaks.css

In conf.yml: externalStyleSheet: ['/assets/dashycsstweaks.css'] (under appConfig).

Every time I've tried to use externalStyleSheet: '/assets/dashycsstweaks.css', an error message shows up in the online edit part saying that externalStyleSheet should be an array, despite the documentation saying that is an ok way to reference.

[Lissy93]

Thanks, that's helpful - I'd totally forgotten ever building that bit 🤣
I'll get a fix pushed out as part of #557 :)

[Lissy93]

Merged in #557 :)

[changbowen]

@Lissy93
This seems to break Google fonts loaded via externalStyleSheet?
Actually change anything in that <link> tag will apply the font.. Not sure why it won't work initially..