Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-482: Enforce parameter splatting instead of backtick in Lombiq.Analyzers.PowerShell #120

Merged
merged 25 commits into from
Dec 20, 2022
Merged

OSOE-482: Enforce parameter splatting instead of backtick in Lombiq.Analyzers.PowerShell #120

merged 25 commits into from
Dec 20, 2022

Conversation

BenedekFarkas
Copy link
Member

@BenedekFarkas BenedekFarkas commented Nov 25, 2022 •
edited
Loading

Piedone
Piedone requested changes Nov 29, 2022
View reviewed changes
.github/actions/verify-submodule-pull-request/Check-Parent.ps1 Outdated Show resolved Hide resolved
.github/actions/build-dotnet/Build-DotNetSolutionOrProject.ps1 Outdated Show resolved Hide resolved
.github/actions/create-jira-issues-for-community-activities/Initialize-IssueDetails.ps1 Outdated Show resolved Hide resolved
.github/actions/create-jira-issues-for-community-activities/Initialize-IssueDetails.ps1 Outdated Show resolved Hide resolved
.github/actions/publish-nuget/New-NuGetPackage.ps1 Outdated Show resolved Hide resolved
.github/actions/setup-sql-server/Initialize-SqlServer.ps1 Outdated Show resolved Hide resolved
.github/actions/test-dotnet/Invoke-SolutionTests.ps1 Outdated Show resolved Hide resolved
.github/actions/test-dotnet/Invoke-SolutionTests.ps1 Outdated Show resolved Hide resolved
.github/actions/test-dotnet/Merge-FailureDumps.ps1 Outdated Show resolved Hide resolved
.github/actions/test-dotnet/Set-XUnitMaxParallelThreads.ps1 Outdated Show resolved Hide resolved
@BenedekFarkas BenedekFarkas mentioned this pull request Dec 19, 2022
Closed
@BenedekFarkas
Copy link
Member Author

Does OSOCE execute PS analysis at all? PS Core analysis is fine locally, but Windows PS throws a ton of analyzer errors for LGHA scripts. IMO it should comply with the same rules as the other repositories where we have PS analysis (Utility and Infrastructure Scripts).

@Piedone
Copy link
Member

Piedone commented Dec 19, 2022

It does, and it does with the same config. There doesn't supposed to be, but might be a difference due to in OSOCE it executing during .NET build, and the other two repos you mention directly by running Invoke-Analyzer.ps1.

@BenedekFarkas
Copy link
Member Author

I see, well, that's not set up correctly then. Lombiq.Analyzers.PowerShell.targets only runs pwsh (if available), powershell is only used as a fallback. EZ fix though.

@Piedone
Copy link
Member

Piedone commented Dec 19, 2022

Oh wait, you're talking about pwsh vs Windows PowerShell. Then it's deliberate that we don't care about Windows PowerShell, the more recent and cross-platform pwsh is what we need to use.

@BenedekFarkas
Copy link
Member Author

Gotcha!

Piedone
Piedone requested changes Dec 20, 2022
View reviewed changes
Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GH sent my comments before I submitted the review somehow, but see the inline comments.

@BenedekFarkas
Copy link
Member Author

@Piedone please check the last two commits and remaining conversations.

@BenedekFarkas BenedekFarkas merged commit f611e3a into dev Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahelsaig sarahelsaig sarahelsaig left review comments

@Piedone Piedone Piedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenedekFarkas @Piedone @sarahelsaig