OSOE-482: Enforce parameter splatting instead of backtick in Lombiq.Analyzers.PowerShell

.github/actions/add-jira-issue-code-to-pull-request/AddJiraIssueCodeToPullRequest.ps1

@@ -2,7 +2,6 @@ param(
     [string] $JiraBaseUrl,
     [string] $GitHubRepository,
     [string] $Branch,
-    [string] $GitHubToken,
     [string] $Title,
     [string] $Body,
     [string] $PullRequestId
@@ -13,30 +12,36 @@ $jiraBrowseUrl = $JiraBaseUrl + '/browse/';
 $originalTitle = $Title
 $originalBody = $Body
 
-if ($Branch -NotLike "*issue*") {
+if ($Branch -NotLike "*issue*")
+{
     Exit
 }
 
 $Branch -match '(\w+-\d+)'
 $issueKey = $matches[0]
 $issueLink = "[$issueKey]($jiraBrowseUrl$issuekey)"
 
-if ($Title -NotLike "*$issueKey*") {
+if ($Title -NotLike "*$issueKey*")
+{
     $Title = $issueKey + ": " + $Title
 }
 
-if (-Not $Body) {
+if (-Not $Body)
+{
     $Body = $issueLink
 }
-elseif ($Body -NotLike "*$issueKey*") {
+elseif ($Body -NotLike "*$issueKey*")
+{
     $Body = $issueLink + "`n" + $Body
 }
-elseif ($Body -NotLike "*``[$issueKey``]``($jiraBrowseUrl$issuekey``)*") {
+elseif ($Body -NotLike "*``[$issueKey``]``($jiraBrowseUrl$issuekey``)*")
+{
     $Body = $Body.replace($issueKey, $issueLink)
 }
 
-if (($Title -ne $originalTitle) -or ($Body -ne $originalBody)) {
-    $bodyParams = @{"title" = $Title; "body" = $Body} | ConvertTo-Json
+if (($Title -ne $originalTitle) -or ($Body -ne $originalBody))
+{
+    $bodyParams = @{"title" = $Title; "body" = $Body } | ConvertTo-Json
     $url = "https://api.github.com/repos/$GitHubRepository/pulls/$PullRequestId"
     Invoke-WebRequest $url -Headers (Get-GitHubApiAuthorizationHeader) -Method Patch -Body $bodyParams
 }

.github/actions/build-dotnet/Build-DotNetSolutionOrProject.ps1

@@ -1,4 +1,4 @@
-param (
+param (
     [string] $Configuration,
     [string] $SolutionOrProject,
     [string] $Verbosity,
@@ -111,7 +111,8 @@ if ($expectedErrorCodes)
         }
     }
 
-    if ($fail -gt 0) {
+    if ($fail -gt 0)
+    {
         Write-Warning $report.ToString() # We use warning so it doesn't stop prematurely.
         Write-Output ("::error::Verification Mismatch " + ($errorLines -join " "))
         exit 1

.github/actions/build-dotnet/Write-CacheConfiguration.ps1

@@ -4,7 +4,7 @@ function Invoke-Maybe($Block) { try { Invoke-Command -ScriptBlock $Block } catch
 
 $paths = @()
 
-if ($IsNuget) { $paths += ,'~/.nuget/packages' }
+if ($IsNuget) { $paths += , '~/.nuget/packages' }
 
 if ($IsNpm)
 {

.github/actions/create-jira-issues-for-community-activities/Initialize-IssueDetails.ps1

@@ -1,4 +1,4 @@
-param
+param
 (
     $GitHub,
     $IssueComponent,

.github/actions/create-jira-issues-for-community-activities/Initialize-IssueTemplates.ps1

@@ -2,7 +2,7 @@
 
 if ([string]::IsNullOrEmpty($Env:DISCUSSION_JIRA_ISSUE_DESCRIPTION))
 {
-    $templates["DISCUSSION_JIRA_ISSUE_DESCRIPTION"] =  @"
+    $templates["DISCUSSION_JIRA_ISSUE_DESCRIPTION"] = @"
 h1. Summary
 See the linked GitHub discussion, including all the comments. Please do all communication there, unless it's confidential or administrative.
 

.github/actions/create-jira-issues-for-community-activities/action.yml

@@ -12,8 +12,8 @@ inputs:
     required: false
     default: "true"
     description: >
-        If set to "true", Jira issue titles will be suffixed with "in <issue-component>" if the issue-component
-        parameter is specified, or the repository name. If set to "false", no suffix will be added to Jira issue titles.
+      If set to "true", Jira issue titles will be suffixed with "in <issue-component>" if the issue-component
+      parameter is specified, or the repository name. If set to "false", no suffix will be added to Jira issue titles.
 
 runs:
   using: "composite"
@@ -100,21 +100,25 @@ runs:
       if: steps.issue-related-pr.outputs.is-issue-pr == 'False'
       shell: pwsh
       run: |
-        # Note that while --fail will fail the command if the request fails, it won't show the server output. Thus,
-        # remove for debugging. --fail-with-body provides that too, but is only available under curl >=7.76.0 which is
-        # not yet available for GitHub Actions, see https://github.com/Lombiq/GitHub-Actions/issues/53.
-        curl --request POST `
-          --url '${{ env.JIRA_BASE_URL }}/rest/api/3/issue/${{ steps.create-issue.outputs.issue }}/remotelink' `
-          --user '${{ env.JIRA_USER_EMAIL }}:${{ env.JIRA_API_TOKEN }}' `
-          --header 'Accept: application/json' `
-          --header 'Content-Type: application/json' `
-          --fail `
-          --data '{
-                \"object\": {
-                    \"url\":\"${{ steps.issue-details.outputs.link-url }}\",
-                    \"title\":\"${{ steps.issue-details.outputs.link-title }}\"
-                }
-            }'
+        $linkProperties = @{
+            object = @{
+                url = '${{ steps.issue-details.outputs.link-url }}'
+                title = '${{ steps.issue-details.outputs.link-title }}'
+            }
+        }
+        $requestParameters = @{
+            Uri = '${{ env.JIRA_BASE_URL }}/rest/api/3/issue/${{ steps.create-issue.outputs.issue }}/remotelink'
+            Method = 'POST'
+            ContentType = 'application/json'
+            Headers = @{
+                Accept = 'application/json'
+                Authorization = 'Basic ' + [Convert]::ToBase64String([Text.Encoding]::UTF8.GetBytes('${{ env.JIRA_USER_EMAIL }}:${{ env.JIRA_API_TOKEN }}'))
+                ContentType = 'application/json'
+            }
+            Body = ConvertTo-Json($linkProperties)
+        }
+
+        Invoke-WebRequest @requestParameters
 
     - name: Update GitHub Issue
       if: steps.issue-related-pr.outputs.is-issue-pr == 'False' && github.event.issue
@@ -126,4 +130,4 @@ runs:
         issue-number: ${{ github.event.issue.number }}
         title: ${{ github.event.issue.title }} (${{ steps.create-issue.outputs.issue }})
         body: "${{ github.event.issue.body }}\n\n[Jira issue](${{ env.JIRA_BASE_URL }}/browse/${{ steps.create-issue.outputs.issue }})"
-        update-mode: 'replace'
+        update-mode: "replace"

.github/actions/msbuild/Build-DotNetFrameworkSolutionOrProject.ps1

@@ -1,4 +1,4 @@
-param (
+param (
     [string] $SolutionOrProject,
     [string] $Verbosity,
     [string] $TreatWarningsAsErrors,
@@ -68,7 +68,7 @@ msbuild $SolutionOrProject @buildSwitches
 
 # error MSB3644: The reference assemblies for .NETFramework,Version=v4.6.1 were not found. To resolve this, install the
 # Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET
-# Framework Developer Packs at https://aka.ms/msbuild/developerpacks 
+# Framework Developer Packs at https://aka.ms/msbuild/developerpacks
 
 if ($?)
 {

.github/actions/publish-nuget/Update-ManifestVersion.ps1

@@ -9,7 +9,8 @@ $manifests = Get-ChildItem $WorkDir -File -Recurse -Filter "Manifest.cs" |
     Select-String -List -Pattern '(OrchardCore.Modules.Manifest|OrchardCore.DisplayManagement.Manifest)' |
     Select-Object -ExpandProperty Path
 
-foreach ($manifest in $manifests) {
+foreach ($manifest in $manifests)
+{
     $regex = '(?<head>\[assembly:\s*(Module|Theme)\(([^\]]*Version\W*=\W*"))([^"]*)', "`${head}$PackageVersion"
     (Get-Content -Raw $manifest) -replace $regex | Out-File $manifest
 

.github/actions/test-dotnet/Invoke-SolutionTests.ps1

@@ -45,7 +45,8 @@ Set-GitHubOutput "test-count" $tests.Length
 
 Write-Output "Starting to execute tests from $($tests.Length) projects."
 
-foreach ($test in $tests) {
+foreach ($test in $tests)
+{
     # This could benefit from grouping, above the level of the potential groups created by the tests (the Lombiq UI
     # Testing Toolbox adds per-test groups too). However, there's no nested grouping, see
     # https://github.com/actions/runner/issues/1477. See the # c341ef145d2a0898c5900f64604b67b21d2ea5db commit for a
@@ -62,8 +63,7 @@ foreach ($test in $tests) {
         # This is for xUnit ITestOutputHelper, see https://xunit.net/docs/capturing-output.
         '--logger', 'console;verbosity=detailed'
         '--verbosity', $Verbosity
-        $Filter ? '--filter' : ''
-        $Filter ? $Filter : ''
+        $Filter ? '--filter', $Filter : ''
         $test
     )
 

.github/actions/test-dotnet/Set-XUnitMaxParallelThreads.ps1

@@ -1,19 +1,19 @@
 param (
-    [Parameter(Mandatory=$true)]
+    [Parameter(Mandatory = $true)]
     $MaxParallelThreads
 )
 
 Write-Output "Setting maxParallelThreads in xunit.runner.json files to $MaxParallelThreads."
 
 $parameters = @{
-        # -Filter is the fastest way to find files because its value is passed directly to the file system API.
-        Filter = "xunit.runner.json"
-        Recurse = $true
-        # -FollowSymLink is needed because without it errors will be thrown of type:
-        # "Get-ChildItem: The system cannot find the path specified."
-        FollowSymlink = $true
-        # Ignore warnings that will be printed due to multiple symlinks pointing to the same physical file.
-        WarningAction = "Ignore"
+    # -Filter is the fastest way to find files because its value is passed directly to the file system API.
+    Filter = "xunit.runner.json"
+    Recurse = $true
+    # -FollowSymLink is needed because without it errors will be thrown of type:
+    # "Get-ChildItem: The system cannot find the path specified."
+    FollowSymlink = $true
+    # Ignore warnings that will be printed due to multiple symlinks pointing to the same physical file.
+    WarningAction = "Ignore"
 }
 
 $configFiles = Get-ChildItem @parameters
@@ -27,7 +27,7 @@ $configFiles | ForEach-Object {
     }
     else
     {
-        $json | Add-Member -Name 'maxParallelThreads' -value $MaxParallelThreads -MemberType NoteProperty
+        $json | Add-Member -Name 'maxParallelThreads' -Value $MaxParallelThreads -MemberType NoteProperty
     }
 
     ConvertTo-Json -InputObject $json > $PSItem

.github/actions/verify-submodule-pull-request/Check-Parent.ps1

@@ -3,12 +3,17 @@
     [string] $Branch
 )
 
-$url = "https://api.github.com/repos/$Repository/pulls?state=open&per_page=100"
-$titles = curl -s -H 'Accept: application/vnd.github.v3+json' $url | ConvertFrom-Json | ForEach-Object { $PSItem.title }
+$ProgressPreference = "SilentlyContinue"
+$requestParameters = @{
+    Uri = "https://api.github.com/repos/$Repository/pulls?state=open&per_page=100"
+    Method = "Get"
+    Headers = @{ Accept = "application/vnd.github.v3+json" }
+}
+$titles = (Invoke-WebRequest @requestParameters).Content | ConvertFrom-Json | ForEach-Object { $PSItem.title }
 
 if (!($Branch -match '(\w+-\d+)'))
 {
-    Exit
+    exit
 }
 
 $issueCode = $matches[0]