-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add features: Silent Pod and Pod Diagnostics #118
Add features: Silent Pod and Pod Diagnostics #118
Conversation
OmniBLE parser improvements
Eliminate user retries on pod setup resumes (Loop issue #2117 follow up)
Allow timezone sync without an active pod
Display additional info in the Deactivate Pod view for a faulted pod
* supports Loop by using DEBUG_FEATURES_ENABLED flag * make suspend message more generic
put Silence Pod and Pod Diagnostics behind build-time flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for extra spaces in allowDebugFeatures if statements and a big concern about using allowDebugFeatures to conditionally enable displaying the Silence Pod option which I believe should always be available. If this option really must be conditional like this, additional thought and code will be needed to properly handle certain possible cases.
This reverts commit 0dfbaae.
The DIY pump managers will not be used by Tidepool, so I reverted the commit that added the allowDebugFeatures check. |
This graphic illustrates the rows that were present before the PR (left side) compared to the display after the PR (right side).
|
This graphic illustrates one of the new Features: Silent Pod
|
This graphic illustrates the other new feature: Pod Diagnostics
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asyncAction
and FirstAppear
are wrongly pushing view model logic into the view.
Cleanup around diagnostic commands
This PR has been updated as requested and is ready for final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This reverts commit adf0692.
…allowDates.isEmpty
This PR adds the Silent Pod and Pod Diagnostics features to the Omnipod screen for DASH pods:
The Silent Pod and Pod Diagnostics rows are added as shown in the graphic below.
User-facing changes:
The before (left) and after (right) screenshots of the Omnipod DASH screen is shown below.