Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features: Silent Pod and Pod Diagnostics #118

Merged
merged 29 commits into from
Apr 13, 2024

Conversation

marionbarker
Copy link
Collaborator

@marionbarker marionbarker commented Apr 2, 2024

This PR adds the Silent Pod and Pod Diagnostics features to the Omnipod screen for DASH pods:

The Silent Pod and Pod Diagnostics rows are added as shown in the graphic below.

User-facing changes:

  • Pod notifications include an option to silence the pod
    • When silenced, alerts are only on the phone, the pod does not beep
    • Pod faults, end of life and out of insulin still alarm on the pod regardless of this setting
  • The previous pod row is moved under the pod details row to make it easier to find
  • A pod diagnostics row is added to the end of the pod screen
    • various diagnostics rows are added in a new sub-screen

The before (left) and after (right) screenshots of the Omnipod DASH screen is shown below.

omnible-pr-117

@marionbarker marionbarker requested review from ps2 and itsmojo April 2, 2024 17:09
Copy link

@itsmojo itsmojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for extra spaces in allowDebugFeatures if statements and a big concern about using allowDebugFeatures to conditionally enable displaying the Silence Pod option which I believe should always be available. If this option really must be conditional like this, additional thought and code will be needed to properly handle certain possible cases.

@marionbarker
Copy link
Collaborator Author

marionbarker commented Apr 3, 2024

The DIY pump managers will not be used by Tidepool, so I reverted the commit that added the allowDebugFeatures check.

@marionbarker
Copy link
Collaborator Author

This graphic illustrates the rows that were present before the PR (left side) compared to the display after the PR (right side).

  1. Rename Device Details to Pod Details
  2. Rename Previous Pod Information to Previous Pod Details
  3. Move the Previous Pod Details to be directly below Pod Details
    • Many users did not know Previous Pod Information existed and did not know where to look for Fault Codes when they needed them
    • Enable the display of Previous Pod Details even with the first pod, indicating that there is no information using the - as opposed to the > when there is a previous pod (compare top half of graphic for first pod to bottom half of graphic for second and subsequent pods)
  4. Add Pod Diagnostics row where Previous Pod Information used to be (details for this in a future comment)

new-pod-screen

@marionbarker
Copy link
Collaborator Author

marionbarker commented Apr 3, 2024

This graphic illustrates one of the new Features: Silent Pod

  • this is incredibly useful when planning to change a pod in the morning and the user does not want the normal alerts that pod has expired or is about to expire, etc to disturb them while sleeping
  • this is also useful for situations when silence is required: during meetings at work, at concerts, in church, etc.
  • Critical faults (or out-of-insulin or out-of-time) alerts still sound on the pod itself
  • This selection is maintained from pod to pod

pod-silent-screen

@marionbarker
Copy link
Collaborator Author

marionbarker commented Apr 3, 2024

This graphic illustrates the other new feature: Pod Diagnostics

  • As we learned with the previous placement of the Previous Pod Information row, this is in a locations most users don't notice
  • It's available to developers who want this capability
  • It's available for trouble-shooting when guided by a mentor
    • Pump manager details can be read easily
    • Eros users can determine the RSSI information for their pod
  • Most of the pod diagnostic commands can be run on a faulted pod (before deactivation)
    • The Read Pod Status display will include more detailed info on the Ref codes for a faulted pod

pod-screen-diagnostics

Copy link

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asyncAction and FirstAppear are wrongly pushing view model logic into the view.

@marionbarker
Copy link
Collaborator Author

This PR has been updated as requested and is ready for final review.

Copy link

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants