Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features: Silent Pod and Pod Diagnostics #32

Merged
merged 28 commits into from
Apr 13, 2024

Conversation

marionbarker
Copy link
Collaborator

@marionbarker marionbarker commented Apr 2, 2024

This PR adds the Silent Pod and Pod Diagnostics features to the OmniKit screen for Eros pods:

The Silent Pod and Pod Diagnostics rows are added as shown in the graphic below.

User-facing changes:

  • Pod notifications include an option to silence the pod
    • When silenced, alerts are only on the phone, the pod does not beep
    • Pod faults, end of life and out of insulin still alarm on the pod regardless of this setting
  • The previous pod row is moved under the pod details row to make it easier to find
  • A pod diagnostics row is added to the end of the pod screen
    • various diagnostics rows are added in a new sub-screen
    • Eros pod users can check their pod RSSI to assist in debugging pump communication issues

The before (left) and after (right) screenshots of the Omnipod screen is shown below.

omnikit-pr-32

@marionbarker marionbarker requested review from itsmojo and ps2 April 2, 2024 17:09
Copy link
Contributor

@itsmojo itsmojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for extra spaces in allowDebugFeatures if statements and a big concern about using allowDebugFeatures to conditionally enable displaying the Silence Pod option which I believe should always be available. If this option really must be conditional like this, additional thought and code will be needed to properly handle certain possible cases.

@marionbarker
Copy link
Collaborator Author

marionbarker commented Apr 3, 2024

The DIY pump managers will not be used by Tidepool, so I reverted the commit that added the allowDebugFeatures check.

@marionbarker
Copy link
Collaborator Author

Graphics for the modified rows and new features are reporting in the OmniBLE PR.

For modified rows:

For new feature: Silent Pod:

For new feature: Pod Diagnostics:

Copy link
Contributor

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ps2 ps2 self-requested a review April 8, 2024 03:46
Copy link
Contributor

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asyncAction and FirstAppear are wrongly pushing view model logic into the view.

@marionbarker
Copy link
Collaborator Author

This PR has been updated as requested and is ready for final review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants