Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kachery storage check, fix name splitting, fix sample rate calc #333

Merged
merged 9 commits into from
Sep 2, 2022

Conversation

rly
Copy link
Collaborator

@rly rly commented Sep 1, 2022

  1. Remove check to see if $KACHERY_STORAGE_DIR exists and is consistent with SPYGLASS_BASE_DIR.
  2. Names with three space-separated items could not be inserted into spyglass because this code:
    labmember_dict['first_name'] = str.split(full_name)[:-1]
    returned an array of strings instead of a string. Here we join those strings with spaces into a single string. This is a stopgap solution until LabMemberInfo should not ask for full_name #304 is resolved.
  3. Fix the sample rate calculation when timestamps are not provided.
  4. Do not import the data_import module when importing spyglass, so that datajoint and mysql are not triggered when loading any spyglass.* module
    • Eventually the processing parts of spyglass will be separated from fetch/insert calls so that they can be tested independently of the database (not yet implemented).
  5. Remove old and no-longer-needed backup spike sorting keys

@rly rly marked this pull request as ready for review September 1, 2022 23:29
@rly rly requested review from edeno, lfrank and khl02007 and removed request for lfrank and edeno September 1, 2022 23:39
src/spyglass/common/common_lab.py Show resolved Hide resolved
@rly rly merged commit f93a29b into master Sep 2, 2022
@rly rly deleted the minor-changes branch September 2, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants