Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support config file-based modification of imported NWB data #334

Closed
wants to merge 87 commits into from

Conversation

rly
Copy link
Collaborator

@rly rly commented Sep 1, 2022

This is a draft PR. Documentation is in progress. Target branch is "minor-changes" currently, because this branch contains all of those changes and would be confusing to review otherwise. The other PR #333 should be merged first.

khl02007 and others added 30 commits August 4, 2022 14:53
This reverts commit a0bf7e9.
This allows us to test certain spyglass functions that do not require a 
database, without having to have a database running
@CBroz1
Copy link
Member

CBroz1 commented Nov 14, 2023

Hi @rly, Hi @khl02007 - This looks like lot of work that never made it in. It this still the best approach for this feature? Can I help out with refactoring and fetching from master? Or do you think we could get rid of this branch? Same for the Giocomo branch?

@rly
Copy link
Collaborator Author

rly commented Nov 23, 2023

I think all of the changes here have made it in, in a different PR, but let me go through this with a fine-toothed comb and double check...

@rly
Copy link
Collaborator Author

rly commented Nov 23, 2023

That Giocomo branch was created by @zoldello and has no new commits compared to master. I think it can be safely deleted. @zoldello do you still need that branch?

@CBroz1
Copy link
Member

CBroz1 commented Nov 27, 2023

Thanks, @rly. In a private message, @zoldello deferred to @khl02007

@edeno
Copy link
Collaborator

edeno commented Dec 14, 2023

I am going to close this PR for now since there doesn't seem to be any action here. It can of course be reopened if there is need.

@edeno edeno closed this Dec 14, 2023
@CBroz1 CBroz1 deleted the giocomo_data branch December 15, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants