[WIP] Standardize schema names, add ImportedSS, revamp SortGroup #372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking up the changes in #334 into smaller PRs...
credit to @khl02007 for most of these changes
Breaking changes:
ArtifactDetectionParameters
->ArtifactDetectionParameter
AutomaticCuration
->MetricAutomaticCuration
AutomaticCurationParameters
->MetricAutomaticCurationParameters
AutomaticCurationSelection
->MetricAutomaticCurationSelection
MetricParameters
->MetricParameter
QualityMetrics
->QualityMetric
UnitInclusionParameters
->UnitInclusionParameter
WaveformParameters
->WaveformParameter
Waveforms
->Waveform
SpikeSortingPreprocessingParameters
->SpikeSortingPreprocessingParameter
SpikeSorterParameters
->SpikeSorterParameter
sortingview_helper_fn
toutils/sortingview_helper_fn
channel
field fromSortingviewWorkspace
SortingviewWorkspace.insert_manual_curation
. It is now hardcoded as “from SortingviewWorkspace”Curation.SpikeSorting
andCuration.ImportedSpikeSorting
part tables instead of havingSpikeSorting
as part of the primary key ofCuration
MetricAutomaticCuration
not have aauto_curation_key
blob field but instead aoutput_curation_id
uuid field.MetricAutomaticCuration.make
would:output_curation_id
MetricAutomaticCuration
Curation
part table with many of the same values plus theoutput_curation_id
SortGroup
now has aProbe.Shank
fieldSortGroup.set_group_by_shank
was updatedSortGroup.set_group_by_electrode_group
SortGroup.get_geometry
Non-breaking changes:
spyglass.spikesorting.spikesorting_sorting.ImportedSpikeSorting