tr2/lara: revert camera after extra anim unless heavy #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Lara_State_Extra_Breath function serves as a bridging animation between an extra animation and Lara returning to normal. This change will respect any heavy camera triggers set during the extra animation rather than blindly resetting to chase type. Resolves LostArtefacts#1580.
lahm86
requested review from
rr-,
walkawayy and
aredfan
and removed request for
a team
rr-
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1580.
Checklist
Description
The
Lara_State_Extra_Breathfunction serves as a bridging animation between an extra animation and Lara returning to normal. This change will respect any heavy camera triggers set during the extra animation rather than blindly resetting to chase type. So as a result it fixes the gong camera in Ice Palace.For testing, we can check WadTool where this could apply elsewhere. Any
Lara misc animationthat has thenext animset to0is relevant:So this gives the following. The camera should return to normal after these animations.