-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tr2/render: add ps1 lighting contrast modes #2055
Conversation
Download the built assets for this pull request: |
😮 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b0eddc0
to
5c03310
Compare
@lahm86 did you upgrade the shaders? It's not supposed to look dark. |
My bad, I built locally and didn't copy those over. Can see the difference now, thanks. |
We need to replace the red eyeglasses with this item: I'd leave it as high or maybe medium as middle ground, to increase this feature's visibility. It's more likely that people who dislike it will look for an option to change this, rather than them looking for an option they might not know exists. |
Ha, snow goggles would be good 😄 |
5c03310
to
14f1a7a
Compare
Thanks – I've changed it to medium. I'll wait for aredfan's approval before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for waiting, I appreciate it. I've tested the different lighting contrast modes and everything LGTM. 👍
Resolves #1646. Implementation similar to TR2Main, with 100%/150%/200% brightness caps.
14f1a7a
to
bdcd43d
Compare
Checklist
Description
Resolves #1646.
Implementation similar to TR2Main, with 100%/150%/200% brightness caps.