Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tr2/render: add ps1 lighting contrast modes #2055

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Dec 16, 2024

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Resolves #1646.
Implementation similar to TR2Main, with 100%/150%/200% brightness caps.

@rr- rr- added Enhancement Improvement of an existing feature TR2 labels Dec 16, 2024
@rr- rr- self-assigned this Dec 16, 2024
@rr- rr- requested review from a team as code owners December 16, 2024 21:00
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team December 16, 2024 21:00
Copy link

github-actions bot commented Dec 16, 2024

@Richard-L
Copy link
Collaborator

😮
I wasn't ready for this, I'm shook!
Can't wait to try the above build.

Copy link
Collaborator

@lahm86 lahm86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to see a difference between medium and high, as below. If these are the intended shades, could we possibly make Low the default setting? I feel med/high would be too dark to offer as default, and low is closest to OG PC.

20241216_212245_The_Great_Wall
20241216_212248_The_Great_Wall
20241216_212252_The_Great_Wall

On med/high the title screen text is difficult to read.
image

src/tr2/config_map.def Outdated Show resolved Hide resolved
src/tr2/game/input.c Outdated Show resolved Hide resolved
src/libtrx/include/libtrx/game/input/roles_tr2.def Outdated Show resolved Hide resolved
@rr- rr- force-pushed the issue-1646-ps1-contrast-levels branch from b0eddc0 to 5c03310 Compare December 16, 2024 21:41
@rr-
Copy link
Collaborator Author

rr- commented Dec 16, 2024

@lahm86 did you upgrade the shaders? It's not supposed to look dark.
20241216_203859_Tibetan_Foothills
20241216_203900_Tibetan_Foothills
20241216_203901_Tibetan_Foothills

@lahm86
Copy link
Collaborator

lahm86 commented Dec 16, 2024

My bad, I built locally and didn't copy those over. Can see the difference now, thanks.
I still prefer Low I have to admit 😄 Flares when on the snow hurt my eyes in med/high, but that could just be me.

@rr-
Copy link
Collaborator Author

rr- commented Dec 16, 2024

My bad, I built locally and didn't copy those over. Can see the difference now, thanks. I still prefer Low I have to admit 😄 Flares when on the snow hurt my eyes in med/high, but that could just be me.

We need to replace the red eyeglasses with this item:
https://en.wikipedia.org/wiki/Snow_goggles
:D

I'd leave it as high or maybe medium as middle ground, to increase this feature's visibility. It's more likely that people who dislike it will look for an option to change this, rather than them looking for an option they might not know exists.

@lahm86
Copy link
Collaborator

lahm86 commented Dec 16, 2024

My bad, I built locally and didn't copy those over. Can see the difference now, thanks. I still prefer Low I have to admit 😄 Flares when on the snow hurt my eyes in med/high, but that could just be me.

We need to replace the red eyeglasses with this item: https://en.wikipedia.org/wiki/Snow_goggles :D

I'd leave it as high or maybe medium as middle ground, to increase this feature's visibility. It's more likely that people who dislike it will look for an option to change this, rather than them looking for an option they might not know exists.

Ha, snow goggles would be good 😄
I think going with medium would be a good move, but happy to go with what the majority think on this. Functionality-wise, it's great 👍

@rr- rr- force-pushed the issue-1646-ps1-contrast-levels branch from 5c03310 to 14f1a7a Compare December 16, 2024 22:17
@rr-
Copy link
Collaborator Author

rr- commented Dec 16, 2024

Thanks – I've changed it to medium. I'll wait for aredfan's approval before merging.

Copy link
Collaborator

@aredfan aredfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for waiting, I appreciate it. I've tested the different lighting contrast modes and everything LGTM. 👍

Resolves #1646.
Implementation similar to TR2Main, with 100%/150%/200% brightness caps.
@rr- rr- force-pushed the issue-1646-ps1-contrast-levels branch from 14f1a7a to bdcd43d Compare December 17, 2024 09:47
@rr- rr- merged commit 3afcc7d into develop Dec 17, 2024
7 checks passed
@rr- rr- deleted the issue-1646-ps1-contrast-levels branch December 17, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement of an existing feature TR2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

PS1 contrast levels
4 participants