feat(dialog-routing): Open dialog through routes #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillerot
force-pushed
the
feat/dialog-routing
branch
from
1242685 to
d4a1440
Compare
Supamiu
previously approved these changes
Jul 1, 2024
GuillaumeNury
previously approved these changes
Jul 1, 2024
g-drouard
reviewed
Jul 29, 2024
| import { ComponentType } from '@angular/cdk/portal'; | ||
| import { firstValueFrom, isObservable, Observable } from 'rxjs'; | ||
|
|
||
| export type Deferrable<T> = Promise<T> | Observable<T> | T; |
There was a problem hiding this comment.
On peut utiliser MayBeAsync fourni par Angular (c'est exactement le même typage)
Merged
Supamiu
approved these changes
Aug 8, 2024
jeremie-lucca
approved these changes
Aug 8, 2024
jeremie-lucca
added a commit
that referenced
this pull request
Aug 22, 2024
* feat(numberFormat): models, functions, pipe, directive, formField for formatted numbers * feat(numberFormat): handle single minusSign in directive input event * feat(numberFormat): cleanup input event listener * feat(numberFormat): based on "Intl number input" library * feat(numberFormat): based on "Intl number input" library * feat(numberFormat): remove autoDecimalDigits & AutoDecimalDigitsNumberMask * feat(numberFormat): refacto number-format models, directive and input component * feat(numberFormat): fix build * feat(numberFormat): add min/max * feat(numberFormat): add stories for currency/unit/percent * feat(numberFormat): fix division on percent value * feat(numberFormat): refacto * test(numberFormat): parse * test(numberFormat): suffix and prefix * feat(numberFormat): auto suffix and prefix are not used by default * test(numberFormat): test focus and blur format * fix(numberFormat): min max behave differently for percent values * Story settings * fix(numberFormat): should use minus sign instead of hyphen for negative values * feat: move all translations to Lokalise * ref(ng): use wider LuTranslation type and deprecate ILuTranslation * ref(ng): remove formatDay as it is not translatable * chore(ng): update translations * chore(ng): update translations * fix(ng): wrong post-i18n prettify * rem(ng): unused translation file * fix(ng): missing translation token exports * fix(ng): wrong LuTranslation import * ref(ng): remove useless fr-CH overrides * feat(storybook): setup LOCALE_ID with browser language * feat(time-picker): AM/PM support (#2888) * feat(time-picker): AM/PM support * display -- + radio AM/PM * feat(time-picker): connect meridiem display to Intl + force input * fix(timepicker): add arrows to AM/PM when enabled * design * autocomplete off * fix stepper position not overlapping focus outline * chore(timepicker): arrow navigation for meridiem part * fix(time-picker): prevent arrowright event on meridiem part * Fix S size on meridian by replacing a spacing token by a input width + padding calculation --------- Co-authored-by: Vincent Valentin <vvalentin@luccasoftware.com> Co-authored-by: Jérémie Biron <jbiron@luccasoftware.com> * Back button for page header (#2948) * fix(date): date adapter format should not be overriden * chore(ng): update translations * [Icons] Add medical + arrow line (#2975) * Update icons (#2979) * [Status badge] Fix vertical alignement in tables (#2986) * Add option luTooltipOnlyForDisplay for tooltips (#2974) * Replace title with heading (#2946) * feat(popover2): hover+focus trigger mode (#2895) * feat(popover2): hover+focus trigger mode * feat(popover2): handle shift+Tab on trigger and add backdrop when opened from focus * feat(popover2): a11y u-mask + better hover+click management * chore: build fix * columnSticky is deprecated (#2928) * feat(plgPush): add new component and all stories (#2911) * Feat(plgBanner): Add new component and all stories * fix(plgBanner): change icon, remove ngif, and set colour by a class * fix(plgBanner): remove empty files, add trads, fix/reorganize css properties * fix(plgBanner): use of inset property, and set variable for svg color path * fix(plgBanner): use vars and change fontsize * fix(plgBanner): fix rocket size * Rename component banner > push * fix(plg-push): build issues * refactor(plgPush): remove link inputs * refactor(plgPush): replace svg by CDN img * fix(plgPush): fix the style of the links * refactor(plgPush): rename input * refactor(plgPush): remove translations * Link wrap + format stories --------- Co-authored-by: Jérémie Biron <jbiron@luccasoftware.com> Co-authored-by: Guillaume Nury <gnury@luccasoftware.com> * feat(schematics): add empty-state-heading migration (#2955) * fix(schematic): hard-coded parameter * feat(schematics): add new angular template utilities * ref(schematics): remove useless postcss-value-parser in icon migration * feat(schematics): add empty-state-heading migration * Fix footer on dialogs with Safari (#2933) * Fix footer on dialogs with Safari * Add comment --------- Co-authored-by: Jérémie Biron <jbiron@luccasoftware.com> * Deprecated for black and white – Add neutral 0 (#2921) * Deprecated for black and white – Add neutral 0 * fallback text * Remove tooltip generated by Safari desktop (#2958) * Remove tooltip generated by Safari desktop * add hack comments --------- Co-authored-by: Jérémie Biron <jbiron@luccasoftware.com> * Show index table link (#2838) * show index table link * extended link * add mod-allowTextSelection * Change disabled colors (#2966) * Change disabled colors * Only for textfields * docs(radio-input): add base usage docs (#2922) * Toast position when footer is present (#2916) * Toast position when footer is present * add comment --------- Co-authored-by: Jérémie Biron <jbiron@luccasoftware.com> * New component: viewTabs (#2498) * tabs * tabs * viewTabs * remove border radius on panels * states * sibling * primary > product * update branch --------- Co-authored-by: Jérémie Biron <jbiron@luccasoftware.com> * fix(core-select): fix former employees param for users core select * feat(popover2): handled popover2 resize after content changed (#2991) * fix(story): dialog story not opening with focus set to first-input (#3007) * [Page header] Component padding (#3012) * feat(dialog-routing): Open dialog through routes (#2901) * feat(dialog-routing): add dialog routing + story * feat(dialog-routing): fix test * feat(dialog-routing): update story * feat(dialog-routing): fix wrongly edited routerLink in story * i18n-text-input (#2890) * i18n-text-input * feat(i18n-text-input): add model manipulation and CVA * chore(i18n-text-input): better Intl implementation * chore(i18n-text-input): remove cultureName from story * chore(i18n-text-input): performance improvements * rename component * feat(multilanguage-input): new validator and check functions * feat(multilanguage-input): support disabled state * fix conflict * chore(multilanguage-input): migrate structure to localize and add tooltip on button * chore(multilanguage-input): put tooltip on button not icon * fix optional classes * fix lint error * fix lint error * remove size applied by default * Icon size with mod-S * Update docs/dialog.md Co-authored-by: Fabien Basmaison <144820795+fbasmaison-lucca@users.noreply.github.com> * Update packages/ng/forms/multilanguage-input/multilanguage-input.component.scss Co-authored-by: Fabien Basmaison <144820795+fbasmaison-lucca@users.noreply.github.com> --------- Co-authored-by: Flavien Normand <contact@flavien-normand.fr> Co-authored-by: Jérémie Biron <jbiron@luccasoftware.com> Co-authored-by: Fabien Basmaison <144820795+fbasmaison-lucca@users.noreply.github.com> * [Divider] Fix margins & icon color (#3018) * indexTable sortable (#2858) * indexTable sortable * linter * step 2 * cleaning * tableSorted > tableSortable * cleaning legacy * [User tile] Move NG style in CSS package (#2940) * rewrite user tile as CSS component * user tile NG package > css * add documentation story * update usertile ng component * remove old user tile scss * cleanup --------- Co-authored-by: Vincent Valentin <vvalentin@luccasoftware.com> * [Avatar] Move style in SCSS (#3015) * rewrite user tile as CSS component * user tile NG package > css * add documentation story * update usertile ng component * remove old user tile scss * avatar basic refactor * legacy * Plug in ng component * clean up * clean up * DOM rework * remove default import + fix conflit issue * Fix potential breaking with placeholder & put back inline-block display * apply mixin on the right class * fix(lu-form-field): aria-labelledby sometimes filling with label id again and again (#3023) * [Popover2] Add option to remove keyboard close button (#3027) * feat(popover2): new input to remove a11y close button & enable that in i18n input * add control to the story --------- Co-authored-by: Flavien Normand <contact@flavien-normand.fr> * [DurationPicker] Fix legend (#3026) * Replace absolute position with grid (#2935) * ref(core-select)!: optionKey is mandatory on ApiDirectives (#2950) * feat(forms): new phone number input component (#3022) * chore(phone-number): init component * feat(forms): new phone number input #2882 * chore(phone-number-input): add missing prefix on pipe * basic inputs UI * feat(phone-number): add country and prefix search * feat(phone-number): add country flags (TODO: align & spacing) * chore(phone-number): make search case insensitive * chore(phone-number): select displayer should show flag only * UI * a11y * chore: fix CI build * label englobant * chore: imports fix * chore(phone-number-input): switch to its own entry point * chore(phone-number-input): remove unneeded try/catch block * chore(phone-number-input): fix deep import --------- Co-authored-by: Jérémie Biron <jbiron@luccasoftware.com> Co-authored-by: Vincent Valentin <vvalentin@luccasoftware.com> * InlineMessage with PortalContent (#2947) * inlineMessage-statusIcon * portalContent * cleanup * stories * feedbacks * cleanup * portalContent --------- Co-authored-by: Adèle Guillerot <aguillerot@luccasoftware.com> Co-authored-by: Guillaume Nury <gnury@luccasoftware.com> Co-authored-by: Guillaume Nury <GuillaumeNury@users.noreply.github.com> Co-authored-by: Flavien Normand <contact@flavien-normand.fr> Co-authored-by: Vincent Valentin <vvalentin@luccasoftware.com> Co-authored-by: Vincent Valentin <64789527+vvalentin-lucca@users.noreply.github.com> Co-authored-by: Nicholas BRUN (Lucca) <nbrun@luccasoftware.com> Co-authored-by: Lucas Brettes <lbrettes@luccasoftware.com> Co-authored-by: Lucas Brettes <lucas.brettes@gmail.com> Co-authored-by: Olivier Braud <144034885+obraud@users.noreply.github.com> Co-authored-by: Fabien Basmaison <144820795+fbasmaison-lucca@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide component, util function, and models to open dialog through routes
Enregistrement.de.l.ecran.2024-06-28.a.12.08.47.mov