-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LF 18.2 #2998
Merged
Merged
LF 18.2 #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[18.1] Update RC
… formatted numbers
[18.1.1] Update RC
…eat/number-format-field
Intl.NumberFormat: Add models, functions, pipe, directive and FormField input
* feat(dialog-routing): add dialog routing + story * feat(dialog-routing): fix test * feat(dialog-routing): update story * feat(dialog-routing): fix wrongly edited routerLink in story
* i18n-text-input * feat(i18n-text-input): add model manipulation and CVA * chore(i18n-text-input): better Intl implementation * chore(i18n-text-input): remove cultureName from story * chore(i18n-text-input): performance improvements * rename component * feat(multilanguage-input): new validator and check functions * feat(multilanguage-input): support disabled state * fix conflict * chore(multilanguage-input): migrate structure to localize and add tooltip on button * chore(multilanguage-input): put tooltip on button not icon * fix optional classes * fix lint error * fix lint error * remove size applied by default * Icon size with mod-S * Update docs/dialog.md Co-authored-by: Fabien Basmaison <144820795+fbasmaison-lucca@users.noreply.github.com> * Update packages/ng/forms/multilanguage-input/multilanguage-input.component.scss Co-authored-by: Fabien Basmaison <144820795+fbasmaison-lucca@users.noreply.github.com> --------- Co-authored-by: Flavien Normand <contact@flavien-normand.fr> Co-authored-by: Jérémie Biron <jbiron@luccasoftware.com> Co-authored-by: Fabien Basmaison <144820795+fbasmaison-lucca@users.noreply.github.com>
* indexTable sortable * linter * step 2 * cleaning * tableSorted > tableSortable * cleaning legacy
* rewrite user tile as CSS component * user tile NG package > css * add documentation story * update usertile ng component * remove old user tile scss * cleanup --------- Co-authored-by: Vincent Valentin <vvalentin@luccasoftware.com>
* rewrite user tile as CSS component * user tile NG package > css * add documentation story * update usertile ng component * remove old user tile scss * avatar basic refactor * legacy * Plug in ng component * clean up * clean up * DOM rework * remove default import + fix conflit issue * Fix potential breaking with placeholder & put back inline-block display * apply mixin on the right class
* feat(popover2): new input to remove a11y close button & enable that in i18n input * add control to the story --------- Co-authored-by: Flavien Normand <contact@flavien-normand.fr>
* chore(phone-number): init component * feat(forms): new phone number input #2882 * chore(phone-number-input): add missing prefix on pipe * basic inputs UI * feat(phone-number): add country and prefix search * feat(phone-number): add country flags (TODO: align & spacing) * chore(phone-number): make search case insensitive * chore(phone-number): select displayer should show flag only * UI * a11y * chore: fix CI build * label englobant * chore: imports fix * chore(phone-number-input): switch to its own entry point * chore(phone-number-input): remove unneeded try/catch block * chore(phone-number-input): fix deep import --------- Co-authored-by: Jérémie Biron <jbiron@luccasoftware.com> Co-authored-by: Vincent Valentin <vvalentin@luccasoftware.com>
* inlineMessage-statusIcon * portalContent * cleanup * stories * feedbacks * cleanup * portalContent
vvalentin-lucca
approved these changes
Aug 22, 2024
Supamiu
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📖 Documentation changes
Requires a Prisme update
🔖🐛 FIX
Bug / Visual fix (PR should target Master branch)
🔖✨ Feature
New feature (even a very small one)
🔨 Technical
Doesn't affect the output (refactor, dependencies update, cleaning, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Actions required to update
Table sorted import
must be replaced by
Users
userTileStyle
mixin import was removed by default to save weight and replaced by a SCSS component. We suggest to replace the mixin import by importing User Tile component (Angular or HTML (🚧 Add link)) or fix it with the deprecated import:🚧 Snippet UI change
userPictureStyle
&userPictureVars
mixins import were removed for the same reason. We suggest to replace mixins import by importing Avatar (HTML) / User Picture (Angular) (🚧 Add link) component or fix it with the deprecated import:Select optionKey
On all classes that extend
ALuCoreSelectApiDirective
, apps have to apps have to implementoptionKey
method:Divider UI spacings
Divider vertical spacing was reduced from
1.5rem
to0.25rem
to fit with Figma component.We suggest to edit margins on divider's surrounding components, but if you need to quickly upgrade, it's possible to override divider margin to avoid UI breakings:
🤖 Schematics
title
input byheading
to avoid browsers native interpretation feat(schematics): add empty-state-heading migration #2955🎉 Features
LOCALE_ID
feat(time-picker): AM/PM support #2888hover
+focus
trigger feat(popover2): hover+focus trigger mode #2895portalContent
InlineMessage with PortalContent #2947Medical
,Arrow line bottom
&Arrow line top
icons [Icons] Add medical + arrow line #2975🎨 Visual changes
neutral 600
byneutral 700
on textfields and apply disabled variable on a bunch of components Change disabled colors #2966neutral 500
toneutral 600
[Divider] Fix margins & icon color #3018🚑 Fixes
optionKey
is mandatory onApiDirectives
ref(core-select)!: optionKey is mandatory on ApiDirectives #2950💬 Translations
🔨 Technical
grid
display on triggers to avoidabsolute
positioning Replace absolute position with grid #29350
value to palettes Deprecated for black and white – Add neutral 0 #2921title
input byheading
to avoid browsers native interpretation Replace title with heading #2946📖 Documentation
💀 Deprecated
Colors variables
--colors-white-color
/--colors-black-color
colors Deprecated for black and white – Add neutral 0 #2921--colors-white-color
must be replaced by--palettes-neutral-0
or--pr-t-elevation-surface-raised
depending if color refer to a surface or not.--colors-black-color
must be replaced by--palettes-neutral-900
.Table
.columnSticky
is replaced by.stickyColumn
(duplicate) columnSticky is deprecated #2928.table-head-row-cell-sortableButton
,.indexTable-head-row-cell-sortableButton
,.table-head-row-cell.mod-sortable
,.table-head-row-cell.sortedAscending
&.table-head-row-cell.sortedDescending
are replaced by a single tableSortable sub-component for Table and Index Table.Users
userTileStyle
is replaced by HTML component import:@forward '@lucca-front/scss/src/components/userTile';
userPictureStyle
&userPictureVars
are replaced by HTML component import:@forward '@lucca-front/scss/src/components/userTile';
Utilities
.u-textLeft
,.u-textCenter
&.u-textRight
are deprecated and replaced by.u-textAlignLeft
,.u-textAlignCenter
&.u-textAlignRight
for consistency.All information related to deprecated elements