Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve CI warnings replacing outdated actions #221

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

andros21
Copy link
Contributor

@andros21 andros21 commented Jun 8, 2023

Issue #, if available

Try to remove noisy warnings inside github actions

Description of changes

Principally by bumping to new tag version (e.g.
action/checkout). But for unmaintained actions the swap
with a fork or something similar, is the only solution:

Two consequences of using dtolnay/rust-toolchain are:

  • no more needed CARGO_TERM_COLOR=always already set by
    the action
  • use directly cargo commands in run steps

I also change deprecated ::set-output commands

A question to complete the PR:
How about actions-rs/tarpauli step? It was responsible for
the failure of general "Rust" workflow before the fork. It's
also unmaintained as all action-rs/*. A possible
replacement can be found, but I don't understand if it's still
used or not

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@LukeMathWalker
Copy link
Owner

Thanks for this, much appreciated!

I'd like to keep (and fix) the tarpaulin job. You can probably use this as a reference implementation.

@andros21
Copy link
Contributor Author

andros21 commented Jun 8, 2023

I've pushed a proposal for fix it, using taiki-e/install-action to install tarpaulin from github-releases of the author, avoiding crate build

Let me know if there is something more I can do here.
Partly related:

  1. to keep actions updated, how about enabling something like dependabot?
  2. can be advisable to set explicitly permissions related to GITHUB_TOKEN,
    for example in "Publish binaries" permissions: {contents: write}

If appreciated I can make these changes in a separate PR

@LukeMathWalker
Copy link
Owner

I'd definitely be open to both changes.
On dependabot: I'd prefer a configuration that doesn't raise PRs unless there is a semver-breaking version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants