Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best practies for github actions: permissions and dependabot #223

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

andros21
Copy link
Contributor

@andros21 andros21 commented Jun 16, 2023

Related: #221

Description of changes:

Explicitly set permissions required inside github actions

For dependabot what you'd prefer for schedule interval?
And for the preference you expressed:

raise PRs unless there is a semver-breaking version bump

I think the closest behavior can be ignoring semver patch release for all actions,
instead minor, major usually can contain some breaking changes. Is it ok?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@LukeMathWalker
Copy link
Owner

I think we can lean on "increase-if-necessary" for Dependabot? (see here)

@andros21
Copy link
Contributor Author

Maybe, I looked at it, but I don't see github-actions ecosystem explicitly mentioned as supported in none of the available update strategies

@LukeMathWalker
Copy link
Owner

Yeah, you're right. Let's stick to your suggestion then.

Weekly schedule interval and ignore patch releases
@andros21
Copy link
Contributor Author

andros21 commented Jun 23, 2023

To benefit from dependabot update checks the last thing that remain to do is to explicitly pin the complete tag version for all github actions used (to avoid rolling tags such as checkout@v3) even better the full commit hash.

Fortunately for this error prone task we can use https://github.com/step-security/secure-repo, I've already previewed changes for full length commit sha pinning: step-security-bot@760092b

If you are ok with this approach, I can let the bot open a PR, and then incorporate its changes here

@LukeMathWalker LukeMathWalker merged commit fc474fb into LukeMathWalker:main Jun 28, 2023
@LukeMathWalker
Copy link
Owner

I prefer to keep a rolling tag, which is why I want to skip patch updates (and perhaps minor, depending on the frequency).
Pinning would just lead to unnecessary PR churn on this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants