Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element icon borders not showing until second click #467

Closed
LeoDanielsson opened this issue Dec 11, 2023 · 3 comments
Closed

Element icon borders not showing until second click #467

LeoDanielsson opened this issue Dec 11, 2023 · 3 comments
Labels
bug Something isn't working as expected

Comments

@LeoDanielsson
Copy link

LeoDanielsson commented Dec 11, 2023

Describe the bug

When activating an element, it does not show the white border around it, making it difficult to see if it's active or not. Especially the "Dark" element which has very poor contrast against the brown background.

When clicking an active element again, a white border gets added which improves visibility a lot. I assume this border is supposed to always be shown for strong/waning elements.

Hover:
bild

After clicking once:
bild

After clicking a second time:
bild

The third click sets it to waning (or consumed if in an active round)
bild

Game Enviroment

Frosthaven Theme

To Reproduce

  1. Click on an inert element once. It fills but does not show a white border.
  2. Click it again. It shows the white border.

Expected behavior

The first click should set it to strong and show the white border.

The second click should set it to waning/inert.

Gloomhaven Secretariat Version

0.83.6.

Used Browser

Firefox 120.0.1 (64-bit)

OS

MacOS 13.4 (Apple Silicon)

Additional

No response

@LeoDanielsson LeoDanielsson added the bug Something isn't working as expected label Dec 11, 2023
@Lurkars
Copy link
Owner

Lurkars commented Dec 11, 2023

This is actually on purpose. When you activate an element during your turn, it is not strong. It becomes strong after you end turn. This is to make clear, that you cannot use the element. I may add a white or maybe gray border to try to make it look more obvious.

@LeoDanielsson
Copy link
Author

Ah, It's just a case of me misunderstanding the UI then. Closing.

Lurkars added a commit that referenced this issue Dec 13, 2023
@Lurkars
Copy link
Owner

Lurkars commented Dec 13, 2023

Thanks, I still added now a bit darker border in v0.83.7.

@Lurkars Lurkars removed their assignment Dec 13, 2023
rdoll pushed a commit to rdoll/gloomhavensecretariat that referenced this issue Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants