Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribute collective resources in scenario rewards #456

Closed
tttopuz opened this issue Nov 29, 2023 · 5 comments
Closed

Distribute collective resources in scenario rewards #456

tttopuz opened this issue Nov 29, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@tttopuz
Copy link

tttopuz commented Nov 29, 2023

Is your feature request related to a problem? Please describe.

After finishing a scenario including collective resources in the scenario rewards, these resources can be distributed among the players or put in the frosthaven supply. These resources are now automatically put in the frosthaven supply. Maybe there could be an option to distribute these among the players in the scenario summary screen.

image

Describe the solution you'd like

Describe alternatives you've considered

Additional context

No response
@tttopuz tttopuz added the enhancement New feature or request label Nov 29, 2023
@Lurkars
Copy link
Owner

Lurkars commented Dec 4, 2023

Totally makes sense! Will add this!

@Lurkars Lurkars added the in progress Currently working on this label Dec 4, 2023
Lurkars added a commit that referenced this issue Dec 5, 2023
@Lurkars
prepare i18n FH monster, address #451, #452, #454 #455, #456, #457, f…
6a912db 
…ix scenario data, fix item rewards
Lurkars added a commit that referenced this issue Dec 9, 2023
@Lurkars
address #451, #456, #465, some scenario summary fixes
a826df0
Lurkars added a commit that referenced this issue Dec 9, 2023
@Lurkars
fixes label for #456
d39776d
@Lurkars
Copy link
Owner

Lurkars commented Dec 9, 2023

Should be implemented in v0.83.6.

@Lurkars Lurkars assigned tttopuz and unassigned Lurkars Dec 9, 2023
@Lurkars Lurkars added to test Should be fixed, but needs proper testing and removed in progress Currently working on this labels Dec 9, 2023
@tttopuz
Copy link
Author

tttopuz commented Dec 12, 2023

It is possible in its current implementation to distribute more resources than rewarded if you type in a number. This could cause some issues with negative numbers if distributed more than is available in frosthaven supply.

Lurkars added a commit that referenced this issue Dec 13, 2023
@Lurkars
address #456, #467, #468, #469, #470
f2b5473
@Lurkars
Copy link
Owner

Lurkars commented Dec 13, 2023

Thanks for noticing this. Should be fixed in v0.83.7. Happy if you can test again.

@tttopuz
Copy link
Author

tttopuz commented Dec 28, 2023

Fixed.

@tttopuz tttopuz closed this as completed Dec 28, 2023
@Lurkars Lurkars removed the to test Should be fixed, but needs proper testing label Dec 28, 2023
rdoll pushed a commit to rdoll/gloomhavensecretariat that referenced this issue Dec 31, 2023
@Lurkars @rdoll
prepare i18n FH monster, address Lurkars#451, Lurkars#452, Lurkars#454 …
5e76e7f 
…Lurkars#455, Lurkars#456, Lurkars#457, fix scenario data, fix item rewards
rdoll pushed a commit to rdoll/gloomhavensecretariat that referenced this issue Dec 31, 2023
@Lurkars @rdoll
address Lurkars#451, Lurkars#456, Lurkars#465, some scenario summary …
82e301a 
…fixes
rdoll pushed a commit to rdoll/gloomhavensecretariat that referenced this issue Dec 31, 2023
@Lurkars @rdoll
fixes label for Lurkars#456
42980fe
rdoll pushed a commit to rdoll/gloomhavensecretariat that referenced this issue Dec 31, 2023
@Lurkars @rdoll
address Lurkars#456, Lurkars#467, Lurkars#468, Lurkars#469, Lurkars#470
3f469f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lurkars @tttopuz