Loot in Scenario Summary only counts coins

[tttopuz]

Describe the bug

At the end of a scenario, in the scenario summary window, the row Loot only counts coins, whereas it should count the number of loot tokens collected.

In this example, it should display Loot 1 for the Geminate.

Game Enviroment

To Reproduce

Expected behavior

Gloomhaven Secretariat Version

Used Browser

OS

Windows

Additional

No response

[Jaerin]

It looks like character.loot was being mistaken for what should be character.gold I think. It looks like instead of just incrementing character.loot it is trying to calculate the value of the items and adding it, but only gold has a value.

applyLoot(loot: Loot, character: Character, index: number): ItemData | undefined {
let result: ItemData | undefined = undefined;
character.lootCards = character.lootCards || [];
if (loot.type == LootType.money || loot.type == LootType.special1 || loot.type == LootType.special2) {
character.loot += this.getValue(loot);
} else if (loot.type == LootType.random_item && this.game.scenario && this.game.party.campaignMode && settingsManager.settings.characterItems && settingsManager.settings.applyLootRandomItem) {
result = gameManager.itemManager.drawRandomItem(this.game.scenario.edition);
if (!result) {
character.loot += 3;
}
}

This seems to be treating character.loot as some kind of a gold value of all the items that have been collected instead of just a count of loot cards. Unless Loot is supposed to be some kind of summary gold value of loot gained but then there should be another loot card count.

[Lurkars]

Yes, this came from Gloomhaven table, where I have the loot row, to show how much coins looted, and below the gold for counting that to gold.

But I think it totally right, that this should count all loot tokens collected, not the gold cards. The big difference here between Gold and other resources is still the gold conversion depending on level. So I am now unsure how to show that number. In current state, this is the loot column.

[Jaerin]

I'm not sure there is a time when you'd need a conversation of items to gold value at least in this situation. The question I have though is in a smaller group where a loot card counts as more than one material does that count as multiple loot cards with regards to personal quests and the like? I could see this being a reason why you'd need to calculate the "value" of the loot card, but I'm not sure on the ruling on that. That was the only reason I could come up with why you'd need to calculate the value of anything other than coins.

[tttopuz]

In my opinion, the number of loot tokens collected should be displayed here. There are for example some battle goals where you need to compare the number of collected loot tokens between players. Actual coins collected is much less important in Frosthaven.

[Lurkars]

Yes, I also think that showing just the total number of collected tokens (e.g. collected loot cards) is here a way better information. In Gloomhaven it's also the number of loot tokens, so showing the number of coins here is just confusing. So this will change in next release. For now I will just skip the info of collected coins. If this is ever required somehow, I can rethink about where to show it.

[Lurkars]

Add in v0.83.4. Happy about feedback and if issue is solved with this. Thank.

[tttopuz]

Top row now displays number of loot tokens. Thanks!