Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Items from ItemShop #452

Closed
dhyanna opened this issue Nov 27, 2023 · 5 comments
Closed

Adding Items from ItemShop #452

dhyanna opened this issue Nov 27, 2023 · 5 comments
Labels
bug Something isn't working as expected

Comments

@dhyanna
Copy link

dhyanna commented Nov 27, 2023

Describe the bug

As part of Frosthaven road event WR-16, my character gained Item 231 (Skinning Knife). After adding the item to the Unlocked Items, I entered the Itemshop via my character sheet. After searching for the item, I was unable to add this item to my character's equipment, presumably because my character did not have enough gold to purchase it. The Select Item option was grayed out and the only option was to Cancel. Upon temporarily adding enough gold to my character to purchase, I was able to Select the item and then add the item without purchasing it.

Game Enviroment

Frosthaven Edition

To Reproduce

  1. Go to Itemshop and see that an item cannot be selected unless there is enough to purchase
  2. Add enough gold to character sheet to purchase
  3. Return to itemshop and select item
  4. Item can then be added to equipment without purchase

Expected behavior

Items should be able to be selected and added to the character sheet without having enough gold to purchase

Gloomhaven Secretariat Version

0.83.2

Used Browser

Firefox 119.0.1

OS

Windows 10 Pro

Additional

No response

@dhyanna dhyanna added the bug Something isn't working as expected label Nov 27, 2023
@keinkurt
Copy link
Contributor

Have you try to double click with mouse or long press on mobile device on the item in the itemshop? The you should see a "Add 'Itemname'". Normally this is the method to force add the item to the character.

@Lurkars
Copy link
Owner

Lurkars commented Nov 28, 2023

Yes, I understand the issue and will address this beside the workaround. Because when I add the possibility to add an item without costs, then this should be available even when item is not purchasable.

@Lurkars Lurkars added the in progress Currently working on this label Nov 28, 2023
Lurkars added a commit that referenced this issue Dec 5, 2023
…ix scenario data, fix item rewards
@Lurkars
Copy link
Owner

Lurkars commented Dec 5, 2023

Should be fixed in v0.83.4.

@Lurkars Lurkars assigned dhyanna and unassigned Lurkars Dec 5, 2023
@Lurkars Lurkars added to test Should be fixed, but needs proper testing and removed in progress Currently working on this labels Dec 5, 2023
rdoll pushed a commit to rdoll/gloomhavensecretariat that referenced this issue Dec 31, 2023
@stonie73
Copy link
Contributor

I just played around with the item shop a lot. I can approve that you have both option in the item shop:

  • add (without paying any gold)
  • buy

Issue seems to be fixed

@dhyanna
Copy link
Author

dhyanna commented Mar 6, 2024 via email

@Lurkars Lurkars removed the to test Should be fixed, but needs proper testing label Mar 6, 2024
@Lurkars Lurkars closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

4 participants