Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo screen doesn't show titles #457

Closed
tttopuz opened this issue Nov 29, 2023 · 6 comments
Closed

Undo screen doesn't show titles #457

tttopuz opened this issue Nov 29, 2023 · 6 comments
Labels
bug Something isn't working as expected

Comments

@tttopuz
Copy link

tttopuz commented Nov 29, 2023

Describe the bug

The undo screen should show titles of the actions, but in my case is always blank.

image

Game Enviroment

To Reproduce

Expected behavior

Gloomhaven Secretariat Version

Used Browser

OS

Additional

No response

@tttopuz tttopuz added the bug Something isn't working as expected label Nov 29, 2023
@Lurkars
Copy link
Owner

Lurkars commented Dec 4, 2023

This looks weird. Do the undo work in general? The text information for the undos/redos is a separate storage, so possible that only this is broken. If still affected, it would be best if you can go to Data Management, Export Data Dump and send this to support@gloomehaven-secretariat.de. So I can take a look at the data directly.

@Lurkars Lurkars assigned tttopuz and unassigned Lurkars Dec 4, 2023
@Lurkars Lurkars added the pending Additional information/feedback requested label Dec 4, 2023
@tttopuz
Copy link
Author

tttopuz commented Dec 5, 2023

The undo's do work and actually undo the action. I will send over the data dump to the mail address provided.

@Lurkars
Copy link
Owner

Lurkars commented Dec 5, 2023

Thanks. At least I could identify one issue with the data. Nevertheless, you got way more undos stored than the undo-informations and I worry, that there is another issue causing this broken state. Anyway, a first fix will come later today!

@Lurkars Lurkars added in progress Currently working on this and removed pending Additional information/feedback requested labels Dec 5, 2023
@Lurkars Lurkars assigned Lurkars and unassigned tttopuz Dec 5, 2023
Lurkars added a commit that referenced this issue Dec 5, 2023
…ix scenario data, fix item rewards
@Lurkars
Copy link
Owner

Lurkars commented Dec 5, 2023

So should be fixed in v0.83.4.

@Lurkars Lurkars assigned tttopuz and unassigned Lurkars Dec 5, 2023
@Lurkars Lurkars added to test Should be fixed, but needs proper testing and removed in progress Currently working on this labels Dec 5, 2023
@tttopuz
Copy link
Author

tttopuz commented Dec 6, 2023 via email

@Lurkars Lurkars removed the to test Should be fixed, but needs proper testing label Dec 6, 2023
@Lurkars Lurkars closed this as completed Dec 6, 2023
@tttopuz
Copy link
Author

tttopuz commented Dec 12, 2023

Just found out that I had typed in 999999 as value in the settings for number of undos. Changing this to a more reasonable number such as 500, fixed this bug for me.

rdoll pushed a commit to rdoll/gloomhavensecretariat that referenced this issue Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants