Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add/remove time token at Blinkblade #451

Closed
keinkurt opened this issue Nov 27, 2023 · 13 comments
Closed

Automatically add/remove time token at Blinkblade #451

keinkurt opened this issue Nov 27, 2023 · 13 comments
Labels
enhancement New feature or request

Comments

@keinkurt
Copy link
Contributor

Is your feature request related to a problem? Please describe.

It's possible to implement the change of amount of Blinkeblades time token based on his declaration of Fast or Slow?

Describe the solution you'd like

Change the amount of time tokens based on the decision of Fast or Slow move at Blinkblade as follow:

  • At the start of scenario BB has 1 time token
  • If BB declare Fast remove 1 time token (and maybe refuse to declare Fast, if BB has no time token)
  • If BB declare Slow add 1 time token, but not add 1 time token if BB has already 2 time tokens

Hopefully I don't miss any rule...

Describe alternatives you've considered

None

Additional context

No response

@keinkurt keinkurt added the enhancement New feature or request label Nov 27, 2023
@Lurkars
Copy link
Owner

Lurkars commented Nov 28, 2023

Yes, this was asked before. I will add a toggle to the character menu to enable/disable this behavior.

@Lurkars Lurkars added the in progress Currently working on this label Nov 28, 2023
Lurkars added a commit that referenced this issue Dec 5, 2023
…ix scenario data, fix item rewards
@Lurkars
Copy link
Owner

Lurkars commented Dec 5, 2023

Should now be added in v0.83.4. You need to activate in the character menu.

@Lurkars Lurkars added to test Should be fixed, but needs proper testing and removed in progress Currently working on this labels Dec 5, 2023
@Lurkars Lurkars assigned keinkurt and unassigned Lurkars Dec 5, 2023
@keinkurt
Copy link
Contributor Author

keinkurt commented Dec 6, 2023

Hey Lurkars, thanks for your work so far, but it's not working corretly. In your implementation, the amount of time tokens only changes if you click on the fast/slow icon. But it should change for every round. Maybe the efect should trigger every round after draw. But I don't know exactly what to do, if the Blinkblade declaring fast and has no time tokens...

@Lurkars
Copy link
Owner

Lurkars commented Dec 7, 2023

Okay, I need to reed into the character mechanics myself to better understand what to implement and how.

@Lurkars Lurkars added in progress Currently working on this pending Additional information/feedback requested and removed to test Should be fixed, but needs proper testing labels Dec 7, 2023
@Lurkars Lurkars assigned Lurkars and unassigned keinkurt Dec 7, 2023
@Lurkars
Copy link
Owner

Lurkars commented Dec 8, 2023

Okay, reading into it... It is changing every round, because you need to DECLARE it at start of every round. So in the end, you need to click on fast/slow before start of every round.
What I change now:

  • time tokens are only added/subtracted after click on Draw, depending on slow/fast
  • when out of tokens and fast is set, on Draw automatically declare slow (and add token)
  • not possible to toggle state during round (so need to be declared "correctly" before round starts, e.g. before Draw)
  • cap max. tokens to five

Hope that make the mechanic works as you wish.

@Lurkars Lurkars removed the pending Additional information/feedback requested label Dec 8, 2023
@keinkurt
Copy link
Contributor Author

keinkurt commented Dec 8, 2023

Yes, this is nearly I want to have see. I have some improvement point...

* when out of tokens and fast is set, on _Draw_ automatically declare slow (and add token)

Maybe it's better to not allow to set to fast, if there is no time token left OR if it will automatically change after drawing, then it will be good to see a warning to confirm these change. (But I would prefer the first solution)

* cap max. tokens to five

Yes the maximum total amount of time tokens are 5, but you can only collect up to 2 time tokens from declaring fast. So, in your implementation you have only to check against the 2 tokens cap. If I declare slow and I have already 2 tokens, then I will not earn 1 additional token. The 5 token cap is only for collecting tokens from abilities.

Hope that make the mechanic works as you wish.

I hope it will not to complicated to implement this!

@Lurkars
Copy link
Owner

Lurkars commented Dec 8, 2023

Yes, this is nearly I want to have see. I have some improvement point...

* when out of tokens and fast is set, on _Draw_ automatically declare slow (and add token)

Maybe it's better to not allow to set to fast, if there is no time token left OR if it will automatically change after drawing, then it will be good to see a warning to confirm these change. (But I would prefer the first solution)

Okay, maybe we need to define, that you're automatically go slow after end of round. By now it doesn't change and so if you're fast (from before) and don't change, then start round, it automatically switches as described (without warning). But if you're automatically slow and then cannot define fast because of no tokens, it should be more clear, right?

* cap max. tokens to five

Yes the maximum total amount of time tokens are 5, but you can only collect up to 2 time tokens from declaring fast. So, in your implementation you have only to check against the 2 tokens cap. If I declare slow and I have already 2 tokens, then I will not earn 1 additional token. The 5 token cap is only for collecting tokens from abilities.

Yes, but you need to add the tokens in GHS anyways (manually) and by now you can add more then 5, so I'll cap that.

@keinkurt
Copy link
Contributor Author

keinkurt commented Dec 9, 2023

Yes, this is nearly I want to have see. I have some improvement point...

* when out of tokens and fast is set, on _Draw_ automatically declare slow (and add token)

Maybe it's better to not allow to set to fast, if there is no time token left OR if it will automatically change after drawing, then it will be good to see a warning to confirm these change. (But I would prefer the first solution)

Okay, maybe we need to define, that you're automatically go slow after end of round. By now it doesn't change and so if you're fast (from before) and don't change, then start round, it automatically switches as described (without warning). But if you're automatically slow and then cannot define fast because of no tokens, it should be more clear, right?

Yes, that looks fine!

* cap max. tokens to five

Yes the maximum total amount of time tokens are 5, but you can only collect up to 2 time tokens from declaring fast. So, in your implementation you have only to check against the 2 tokens cap. If I declare slow and I have already 2 tokens, then I will not earn 1 additional token. The 5 token cap is only for collecting tokens from abilities.

Yes, but you need to add the tokens in GHS anyways (manually) and by now you can add more then 5, so I'll cap that.
Yes, I'm full agree with this!

Thanks a lot for your work!

@Lurkars
Copy link
Owner

Lurkars commented Dec 9, 2023

Should be now implemented in v0.83.6

@Lurkars Lurkars assigned keinkurt and unassigned Lurkars Dec 9, 2023
@Lurkars Lurkars added to test Should be fixed, but needs proper testing and removed in progress Currently working on this labels Dec 9, 2023
@keinkurt
Copy link
Contributor Author

I test it a little bit and it seems to work. But I have one small improvement suggestion, please let the blinkblade has one token at the beginning of the scenario, as it described on the character mat. Thanks!

@Lurkars
Copy link
Owner

Lurkars commented Dec 17, 2023

Yes, will be added. It was there before, but due to the changes I forgot about this!

@Lurkars
Copy link
Owner

Lurkars commented Dec 17, 2023

Thanks, should be implemented now in v0.83.8.

@keinkurt
Copy link
Contributor Author

Thank you very much! I seems to work as expected.

@Lurkars Lurkars removed the to test Should be fixed, but needs proper testing label Dec 25, 2023
rdoll pushed a commit to rdoll/gloomhavensecretariat that referenced this issue Dec 31, 2023
rdoll pushed a commit to rdoll/gloomhavensecretariat that referenced this issue Dec 31, 2023
rdoll pushed a commit to rdoll/gloomhavensecretariat that referenced this issue Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants