Feature/sdl 0084 progress bar seek #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychernysheva
requested changes
Jun 4, 2021
MOBILE_API.xml
Outdated
| @@ -3223,7 +3223,8 @@ | |||
| <element name="OnUpdateFileID" value="32789" hexvalue="8015" since="7.0" /> | |||
| <element name="OnUpdateSubMenuID" value="32790" hexvalue="8016" since="7.0" /> | |||
| <element name="OnAppCapabilityUpdatedID" value="32791" hexvalue="8017" since="7.1"/> | |||
|
|
|||
| <element name="OnSeekMediaClockTimerID" value="32792" hexvalue="8018" since="7.1" /> | |||
There was a problem hiding this comment.
Please align with previous rows, and also at least change to "since 7.2", because we prepare feature to release >7.1
Also please add all this changes to README.md with corresponding python script
| @@ -6227,6 +6228,11 @@ | |||
| e.g. If this parameter is set to `0.5`, the timer will advance one second per two seconds real-time, or at 50% speed. If this parameter is set to `2.0`, the timer will advance two seconds per one second real-time, or at 200% speed. | |||
| </description> | |||
| </param> | |||
| <param name="enableSeek" type="Boolean" mandatory="false" since="7.1"> | |||
| @@ -9153,6 +9159,13 @@ | |||
| </param> | |||
| </function> | |||
|
|
|||
| <function name="OnSeekMediaClockTimer" functionID="OnSeekMediaClockTimerID" messagetype="notification" since="7.1"> | |||
There was a problem hiding this comment.
Same as before, and please add more space before See StartTime.
VadymLuchko
approved these changes
Jun 7, 2021
ychernysheva
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements ***
This PR is ready for review.
Summary
Adds new structs and enums to MOBILE API and README corresponding to proposal
CLA