Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sdl 0084 progress bar seek #16

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Feature/sdl 0084 progress bar seek #16

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
164266f
Add new parameter for SetMediaClockTimer. Add OnSeekMediaClockTimer n…
VladSemenyuk Jun 2, 2021
3f97131
Add "since" attribute
VladSemenyuk Jun 3, 2021
d267a74
Add since atribute to a new param
VladSemenyuk Jun 4, 2021
dd7592f
Fix indents
VladSemenyuk Jun 7, 2021
80ea99f
Add new fields in readme
VladSemenyuk Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion MOBILE_API.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3223,7 +3223,8 @@
<element name="OnUpdateFileID" value="32789" hexvalue="8015" since="7.0" />
<element name="OnUpdateSubMenuID" value="32790" hexvalue="8016" since="7.0" />
<element name="OnAppCapabilityUpdatedID" value="32791" hexvalue="8017" since="7.1"/>

<element name="OnSeekMediaClockTimerID" value="32792" hexvalue="8018" since="7.1" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align with previous rows, and also at least change to "since 7.2", because we prepare feature to release >7.1
Also please add all this changes to README.md with corresponding python script


<!--
Ford Specific Request / Response RPCs
Range = 0x 0001 0000 - 0x 0001 7FFF
Expand Down Expand Up @@ -6227,6 +6228,11 @@
e.g. If this parameter is set to `0.5`, the timer will advance one second per two seconds real-time, or at 50% speed. If this parameter is set to `2.0`, the timer will advance two seconds per one second real-time, or at 200% speed.
</description>
</param>
<param name="enableSeek" type="Boolean" mandatory="false" since="7.1">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change since

<description>
Defines if seek media clock timer functionality will be available. If omitted, the value is set to false. The value is retained until the next SetMediaClockTimer is sent.
</description>
</param>
</function>

<function name="SetMediaClockTimer" functionID="SetMediaClockTimerID" messagetype="response" since="1.0">
Expand Down Expand Up @@ -9153,6 +9159,13 @@
</param>
</function>

<function name="OnSeekMediaClockTimer" functionID="OnSeekMediaClockTimerID" messagetype="notification" since="7.1">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before, and please add more space before See StartTime.

<description> Callback for the seek media clock timer notification. Notifies the application of progress bar seek event on the mediaclock timer. System will automatically update the media clock timer position based on the seek notification location. </description>
<param name="seekTime" type="StartTime" mandatory="true">
<description>See StartTime.</description>
</param>
</function>

<!-- ~~~~~~~~~~~~~~~~~~ -->
<!-- Ford Specific APIs -->
<!-- ~~~~~~~~~~~~~~~~~~ -->
Expand Down