This repository has been archived by the owner on Dec 25, 2023. It is now read-only.
Support upload_processing_limit #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
approved these changes
Feb 13, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
|
Also fixes: LycheeOrg/Lychee#443 |
kamil4
commented
Feb 14, 2021
| @@ -50,7 +50,7 @@ let lychee = { | |||
|
|
|||
| album_subtitle_type: "oldstyle", | |||
|
|
|||
| upload_processing_limit: 4, | |||
| upload_processing_limit: 2, | |||
There was a problem hiding this comment.
Why did you change it to 2? And why only in this least important place?
kamil4
commented
Feb 14, 2021
| @@ -252,7 +252,7 @@ lychee.init = function () { | |||
| lychee.admin = !lychee.api_V2; | |||
| lychee.nsfw_visible_saved = lychee.nsfw_visible; | |||
|
|
|||
| lychee.upload_processing_limit = parseInt(data.config.upload_processing_limit); | |||
| lychee.upload_processing_limit = parseInt(data.config.upload_processing_limit) || 4; | |||
There was a problem hiding this comment.
This is wrong. This prevents the value of 0 from being used. I don't think we can use this || syntax for numerals that can be 0.
There was a problem hiding this comment.
Hummmm indeed, I did not think about this. The problem is that if you send null to parseInt you get NaN which obviously crash all the upload checks afterwards.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a limit on the number of photos being simultaneously processed during upload. I expected that adding this would complicate the
processfunction but in fact it simplified it (since it was needlessly complicated to begin with).This implements what was discussed in LycheeOrg/Lychee#903 and LycheeOrg/Lychee#913. The default limit is
4. Setting it to0disables the limit.There will be a trivial corresponding server-side PR that adds a config variable.