Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upload_processing_limit config variable #919

Merged
merged 3 commits into from
Feb 13, 2021
Merged

Conversation

kamil4
Copy link
Contributor

@kamil4 kamil4 commented Feb 13, 2021

@kamil4 kamil4 requested a review from ildyria February 13, 2021 05:36
@codecov
Copy link

codecov bot commented Feb 13, 2021

Codecov Report

Merging #919 (41350a3) into master (cc6362a) will decrease coverage by 1.63%.
The diff coverage is n/a.

@sunosv
Copy link

sunosv commented Feb 13, 2021

Can the limit set to more than 4? Could Set the values based on server performance?

@d7415
Copy link
Contributor

d7415 commented Feb 13, 2021

Can the limit set to more than 4?

Looks like it

Could Set the values based on server performance?

The user can make that decision. Automatically setting this seems way out of scope.

Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ildyria
Copy link
Member

ildyria commented Feb 13, 2021

Can the limit set to more than 4? Could Set the values based on server performance?

Once this is merged, you can just go into your advanced setting and change the value yourself. :)

@sunosv
Copy link

sunosv commented Feb 13, 2021

Once this is merged, you can just go into your advanced setting and change the value yourself. :)

ok, one more question,When is the next version come out?

@ildyria
Copy link
Member

ildyria commented Feb 13, 2021

ok, one more question,When is the next version come out?

Please define "next" version:

  • Do you mean 5.0 ?
  • Do you mean 4.2.2 ?
  • Do you mean on Docker ?
  • Do you mean as a zip file ?

@sunosv
Copy link

sunosv commented Feb 13, 2021

Please define "next" version:

  • Do you mean 5.0 ?
  • Do you mean 4.2.2 ?
  • Do you mean on Docker ?
  • Do you mean as a zip file ?

Sorry,I mean the 4.2.2

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ildyria
Copy link
Member

ildyria commented Feb 13, 2021

Please define "next" version:

  • Do you mean 5.0 ?
  • Do you mean 4.2.2 ?
  • Do you mean on Docker ?
  • Do you mean as a zip file ?

Sorry,I mean the 4.2.2

I would say, pretty much soon. Most likely once this is merged or after #907 is merged.

@ildyria ildyria merged commit dcad64e into master Feb 13, 2021
@ildyria ildyria deleted the processing-limit branch February 13, 2021 12:26
@ildyria
Copy link
Member

ildyria commented Feb 16, 2021

@sunosv
Copy link

sunosv commented Feb 16, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants