Skip to content
This repository has been archived by the owner on Dec 25, 2023. It is now read-only.

Fix various GUI issues #349

Merged
merged 3 commits into from
Nov 6, 2022
Merged

Fix various GUI issues #349

merged 3 commits into from
Nov 6, 2022

Conversation

nagmat84
Copy link
Collaborator

@nagmat84 nagmat84 commented Nov 6, 2022

This PR fixes various GUI which @kamil4 discovered during his tests of #323 (see #323 (comment)), but which already affect the current master. I hope I fixed all of them without breaking anything else. 🙈

I also hijacked @ildyria PR LycheeOrg/Lychee#1578 for the backend to sync these fixes. Hence, you can simply checkout LycheeOrg/Lychee#1578 to test the changes.

@kamil4 wrote in #323 (comment)

Uploading to the root album (albums view) doesn't work for an admin for me (weirdly, it seems to pass an ID of one of the tag albums in the Photo:add request?!). Unusually, it works for non-admin users.

Should be fixed by aaa6f38. While the fix itself seems to be easy, I added a lot of comments to warn about the fragility of the code.

Album owners don't get to see the "Share" button in the header until the album is made public and the "Share button is visible" is checked.

Should be fixed by 1286b08. This bug seems to be around for a very long time now. I don't have any non-admin users for my gallery and even if I had I assume I would not have noticed that bug.

When the album is made public and the "Share button is visible" is checked, going (as an authenticated owner) to one of the photos inside the album and opening the visibility dialog is supposed to display read-only visibility status, in this case including a checked "Share button is visible". But that button is not checked.

Should be fixed by 0e02359. This one was a silly oversight when migrating to the new modal dialog.

@nagmat84 nagmat84 requested a review from a team November 6, 2022 12:34
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ildyria ildyria merged commit fbcff79 into master Nov 6, 2022
@ildyria ildyria deleted the fix_various_gui_issues branch November 6, 2022 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants