Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix smart albums rights #1578

Merged
merged 5 commits into from
Nov 6, 2022
Merged

fix smart albums rights #1578

merged 5 commits into from
Nov 6, 2022

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Nov 5, 2022

Sync front.

@ildyria ildyria requested a review from a team November 5, 2022 14:36
@codecov
Copy link

codecov bot commented Nov 5, 2022 •
edited
Loading

Codecov Report

Merging #1578 (cdea67d) into master (0fc21a4) will decrease coverage by 0.74%.
The diff coverage is n/a.

❗ Current head cdea67d differs from pull request most recent head a8ec4cf. Consider uploading reports for the commit a8ec4cf to get more accurate results

Additional details and impacted files

@ildyria ildyria added this to the 4.6.2 milestone Nov 5, 2022
@ildyria ildyria added the High Priority High priority issues label Nov 5, 2022
nagmat84
nagmat84 requested changes Nov 6, 2022
View reviewed changes
Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only request changes, because @kamil4 discovered some more bugs (e.g. the share album icon bug) which also affect current master. I would like to fix those first on the frontend before we sync it.

@nagmat84 nagmat84 mentioned this pull request Nov 6, 2022
Merged
@ildyria ildyria merged commit 5bdd75e into master Nov 6, 2022
@ildyria ildyria deleted the hot-fix-smart-albums branch November 6, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

@nagmat84 nagmat84 nagmat84 approved these changes

Assignees
No one assigned
Labels
High Priority High priority issues
Projects
None yet
Milestone
4.6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ildyria @nagmat84 @qwerty287