CD workflow for uploading Entities #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add requirements file with the `entities-service` requirement.
…s' into cwa/close-4-cd-onto-ns-deploy
It is also necessary to use the new SOURCE... input feature, which has not yet been implemented in the entities-service CLI, but is currently a PR. Hence, the version for the package has been set to a higher version than the actual current latest version.
…s' into cwa/close-4-cd-onto-ns-deploy
Note, as of writing, it is not yet released.
sygout
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
Add a new CI/CD workflow that will run on all pull requests and pushes to
main.It will gather all changed entities and validate them.
If it is run as a result of a push to the
mainbranch, it will also, subsequently, upload the entities to onto-ns.com.A valid entity means it matches the (pydantic) model from entities-service as well as not being different from an existing entity on onto-ns.com, while retaining the same URI.
To do:
entities-service uploadcommand with a--no-summaryoption or a similar--no-final-confirmationoption?Issue: ✨ Add an option to the
uploadcommand to auto-confirm the summary SINTEF/entities-service#119PR: New
--auto-confirm/-yoption foruploadcmd SINTEF/entities-service#121entities-service validatecommand or similar.Issue: ✨ Add a new
validatecommand SINTEF/entities-service#118PR: Add a new 'validate' CLI command SINTEF/entities-service#120
entities-servicedynamic with respect to actually changed/added Entities.This has been done, sort of, but a new way of providing inputs is needed.
PR: Run
entities-service validateas a pre-commit hook SINTEF/entities-service#126Issue: ✨ Support piping in SOURCE's (filepaths and directories) SINTEF/entities-service#130
PR: Support using stdin as input for CLI SINTEF/entities-service#131
--strictoption tovalidate(andupload) to ensure not changes will be done automagically.Issue: ✨ New option
--strictfor thevalidatecommand SINTEF/entities-service#129PR: Add
--strictoption to CLI SINTEF/entities-service#132