Add a new 'validate' CLI command #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It returns a list of validated `Entity`s, i.e., `Entity` pydantic model instances. But only if all supplied sources supply readable and valid entities with unique URIs.
CasperWA
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 89.84% 92.01% +2.16%
==========================================
Files 21 26 +5
Lines 1192 1315 +123
==========================================
+ Hits 1071 1210 +139
+ Misses 121 105 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Only when using 'validate' as a "normal" Python function.
Create a new CLI submodule 'commands', wherein each CLI command gets its own submodule. The commands are then added to the CLI through a dynamic retrieval method in the 'commands' submodule, similar to what it done for the Service routers.
Copy over tests from the 'upload' command. Some are even moved, as all validation (even for inputs) for the 'upload' command is now done in the 'validate' command.
Validation tests can now be run, since they are not mixed with the "uploading" logic, and they do not need authentication.
Valid JSON. No timeouts, just - a 500 Internal Server Error response.
This was referenced Apr 12, 2024
CasperWA
added
the
BLOCKING
Treesarj
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118
The new 'validate' command returns a list of validated
Entitys, i.e.,Entitypydantic model instances. But only if all supplied sources supply readable and valid entities with unique URIs.To do:
filepathin the error messages.