Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stac ipyleaflet docs #190

Merged
merged 16 commits into from
May 30, 2023
Merged

Add stac ipyleaflet docs #190

merged 16 commits into from
May 30, 2023

Conversation

emmalu
Copy link
Collaborator

@emmalu emmalu commented May 10, 2023

Draft version of documentation that corresponds with new stac_ipyleaflet package for MAAP.

New Item in TOC

Docs with sub-sections

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@emmalu emmalu added the documentation Improvements or additions to documentation label May 10, 2023
@emmalu emmalu marked this pull request as draft May 10, 2023 20:15
@emmalu emmalu marked this pull request as ready for review May 12, 2023 11:43
@emmalu emmalu requested a review from wildintellect May 15, 2023 18:03
Copy link
Collaborator

@wildintellect wildintellect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we somehow need to indicate which ADE Workspace this currently works on, and that this tool is Alpha/Beta - report issues to .... in a note block at the top perhaps?

@emmalu
Copy link
Collaborator Author

emmalu commented May 16, 2023

So we somehow need to indicate which ADE Workspace this currently works on, and that this tool is Alpha/Beta - report issues to .... in a note block at the top perhaps?

Sure - currently the package works in this env:
https://ade.maap-project.org/

I had (Beta) at the end of the page name - is there somewhere else where you see we need to add that?
Screenshot 2023-05-16 at 4 19 42 PM

Is there an email address you'd like me to add for questions? Or is it ok to direct users to the repo to post issues there?

Copy link
Contributor

@omshinde omshinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Display button for STAC visualization doesn't get active for any dataset I tried. Is that a WIP? If yes, rest of the things work perfectly as described in the existing 0.2.0 version of the notebook (Will wait for confirmation and approving the PR). Thanks for your efforts!

@emmalu
Copy link
Collaborator Author

emmalu commented May 22, 2023

The Display button for STAC visualization doesn't get active for any dataset I tried.

It's true - most of the datasets are not yet compatible. The last one (NASA_JPL_global_agb_mean_2020) should work well for display. Could you give that one a try @omshinde?

@emmalu emmalu requested a review from wildintellect May 23, 2023 18:53
Copy link
Collaborator

@wildintellect wildintellect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we get it to work consistently, this notebook is fine with me for alpha release.

Copy link
Contributor

@omshinde omshinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still facing issues in visualizing the STAC files but it seems to be more of ipywidget issue. Thanks @emmalu for your efforts!

@smk0033
Copy link
Contributor

smk0033 commented May 24, 2023

Same as Rajat, I've been having issues with STAC filters. I also had trouble with the first Paraguay filter, but I believe Jamison said y'all were working on that. One other very minor thing is when I'm panning around and zooming in and out, sometimes the contents in the layers window and the zoom in/out buttons are highlighted, but I also know y'all have been working on some minor bug fixes. Overall, seems like a really neat tool!!

@wildintellect
Copy link
Collaborator

@emmalu The "install" method is now changed. Users need to launch a Pangeo workspace in ade.maap-project.org , no additional install is required after that. Move the install instructions to a note/advanced topic or the end. Then this should be complete.

@emmalu emmalu requested a review from jjfrench May 30, 2023 13:52
@emmalu emmalu requested a review from jjfrench May 30, 2023 14:12
…ipynb

Co-authored-by: Jamison French <50224594+jjfrench@users.noreply.github.com>
@emmalu emmalu requested a review from jjfrench May 30, 2023 14:31
Copy link
Contributor

@jjfrench jjfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🥳

@emmalu emmalu merged commit 0d15518 into develop May 30, 2023
@wildintellect wildintellect deleted the add-stac-ipyleaflet-docs branch July 20, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants