-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stac ipyleaflet docs #190
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we somehow need to indicate which ADE Workspace this currently works on, and that this tool is Alpha/Beta - report issues to .... in a note block at the top perhaps?
Sure - currently the package works in this env: I had (Beta) at the end of the page name - is there somewhere else where you see we need to add that? Is there an email address you'd like me to add for questions? Or is it ok to direct users to the repo to post issues there? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Display button for STAC visualization doesn't get active for any dataset I tried. Is that a WIP? If yes, rest of the things work perfectly as described in the existing 0.2.0 version of the notebook (Will wait for confirmation and approving the PR). Thanks for your efforts!
It's true - most of the datasets are not yet compatible. The last one (NASA_JPL_global_agb_mean_2020) should work well for display. Could you give that one a try @omshinde? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming we get it to work consistently, this notebook is fine with me for alpha release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still facing issues in visualizing the STAC files but it seems to be more of ipywidget
issue. Thanks @emmalu for your efforts!
Same as Rajat, I've been having issues with STAC filters. I also had trouble with the first Paraguay filter, but I believe Jamison said y'all were working on that. One other very minor thing is when I'm panning around and zooming in and out, sometimes the contents in the layers window and the zoom in/out buttons are highlighted, but I also know y'all have been working on some minor bug fixes. Overall, seems like a really neat tool!! |
@emmalu The "install" method is now changed. Users need to launch a Pangeo workspace in ade.maap-project.org , no additional install is required after that. Move the install instructions to a note/advanced topic or the end. Then this should be complete. |
docs/source/technical_tutorials/visualization/stac_ipyleaflet.ipynb
Outdated
Show resolved
Hide resolved
…ipynb Co-authored-by: Jamison French <50224594+jjfrench@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🥳
Draft version of documentation that corresponds with new
stac_ipyleaflet
package for MAAP.