Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init working version commit #55

Merged
merged 33 commits into from
May 25, 2023
Merged

init working version commit #55

merged 33 commits into from
May 25, 2023

Conversation

emmalu
Copy link
Collaborator

@emmalu emmalu commented May 5, 2023

Updates include:

  • UI refresh
  • Layers widget that includes:
    -- Organized Biomass Layers with opacity control
    -- Select Basemap Layers with opacity control
  • STAC widget that:
    -- is connected to the MAAP stac catalog (that is currently in transition so not all datasets are available as of 5/5)
    -- automatically searches/matches items per selected collection
    -- checks for COGs and, if valid, allows user to add data to the map
    -- allows the user to change the selected color palette for rendering the selected item (color palettes have been organized into their respective categories for easier navigation)

Biomass Layers UI

Basemaps UI

STAC Widget UI

STACT Viz Palette UI

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@emmalu
Copy link
Collaborator Author

emmalu commented May 17, 2023

@abarciauskas-bgse @wildintellect

The latest changes include:

  • integrating a better Draw Tools UX that aligns with other current design decisions (with output coordinates shown as code)
  • COG integration of new JPL Global Above Ground Biomass layers (with the ability to update color palettes)
  • synced with main branch changes to ensure successful install / testing from within the ADE environment

Latest Fast Browse v2 UI snapshot of JPL dataset in blues

cc @heidimok @zacharyDez @edkeeble

@emmalu emmalu requested a review from emileten May 18, 2023 19:29
@emmalu
Copy link
Collaborator Author

emmalu commented May 18, 2023

@emileten @jjfrench @abarciauskas-bgse
The package is ready to be installed/tested, following these docs:
MAAP-Project/maap-documentation#190
View Directly in ReviewNB

Use the branch name when installing, in order to see v2 updates:
pip install git+https://github.com/MAAP-Project/stac_ipyleaflet.git@dev/wug-map-refresh#egg-info=stac_ipyleaflet

cc @wildintellect

@emmalu emmalu requested a review from jjfrench May 24, 2023 10:12
@jjfrench
Copy link
Contributor

The revamped UI looks ✨! Just a few questions/comments

  • The histogram feature doesn't seem to be accessible, I wasn't in the project kickoff meeting but was this discussed as something to remove? (What Draw and Layers were originally used for)
  • Should users only be allowed to draw one bounding box? I'm able to draw more than one; the draw tool gets stuck on "release mouse to finish drawing" when I attempt to draw a second bbox.
  • There's no way to "change opacity"/remove a STAC item - issue when trying to display a STAC item and Biomass layer in the same region
  • Minor: Selecting a collection populates the items, selecting the item dropdown shows the first item selected but the dropdown value isn't set. Maybe deselect the first item in the dropdown or fill the dropdown value to the first item in the list?
  • Minor: Displaying an item on the map attempts to center the map on the STAC item but often the overlay ends up behind the widget. Maybe an offset to center the map a little farther right?
  • Minor: Several of the Biomass layers use zoom >= 8 but the current zoom level isn't shown.

@wildintellect
Copy link
Collaborator

  • The histogram feature doesn't seem to be accessible, I wasn't in the project kickoff meeting but was this discussed as something to remove? (What Draw and Layers were originally used for)

Moved to future scope for re-implementation.

output.clear_output()
print(f"{len(options)} items were found - please select 1 to determine if it can be displayed.")
items = list(collection_items.keys())
default = [defaultItemsDropdownText]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little unintended, but the default text "is_displayable". I think that's probably fine though?

Copy link
Contributor

@jjfrench jjfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the widget's features - looks good for 0.2.0!

@emmalu emmalu merged commit cf4b8cf into main May 25, 2023
@emmalu emmalu mentioned this pull request Jun 6, 2023
@wildintellect wildintellect deleted the dev/wug-map-refresh branch September 27, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants