Faster execution and a new pseudo-instruction #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… IR (consistent with textbook). Change ALU control signals to be consistent with textbook. Change control signals in SkipCond to reflect the PC increment step rather than the ALU test.
… delay of 10ms is used, makes some programs far too slow)
Can be used to load the address of a label (less confusing than abusing JnS for that purpose)
ericjiang97
reviewed
Aug 10, 2018
| var realDelay = delay; | ||
| var itersPerLoop = 1; | ||
| if (realDelay < 10) { | ||
| realDelay = 10; |
There was a problem hiding this comment.
What is this realDelay variable used for?
I don't see it used anywhere else, unless its used to replace the delay variable inside the setInterval function
There was a problem hiding this comment.
Of course that was the plan... Doesn't make any difference though because JS seems to assume a minimum of 10 ms anyway. I've fixed this (see commit below). I've also added a fix for a travis ci problem.
|
PR has been approved. Version also increment to v1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains some minor UI fixes, and two bigger changes: