Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from pkg_resources to importlib #4055

Closed
lilyminium opened this issue Mar 6, 2023 · 0 comments · Fixed by #4056
Closed

Move away from pkg_resources to importlib #4055

lilyminium opened this issue Mar 6, 2023 · 0 comments · Fixed by #4056
Assignees
@IAlibay
Milestone
2.5.0

Comments

@lilyminium
Copy link
Member

Is your feature request related to a problem?

We use pkg_resources to get filenames from the test suite. This may be going away in the future, as use of pkg_resources is now deprecated: pypa/setuptools#3843

Describe the solution you'd like

Setuptools encourages moving towards importlib.

Describe alternatives you've considered

Additional context
@IAlibay IAlibay mentioned this issue Mar 6, 2023
Merged
4 tasks
@IAlibay IAlibay added this to the 2.5.0 milestone Mar 30, 2023
@IAlibay IAlibay self-assigned this Apr 12, 2023
IAlibay added a commit that referenced this issue May 25, 2023
@IAlibay
Switching to importlib resources (#4056)
5ab95ec 
Fixes #4055

MDAnalysisTests now returns an `as_posix()` string using importlib instead of pkg_resources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IAlibay IAlibay

Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

Switching to importlib resources MDAnalysis/mdanalysis
2 participants
@IAlibay @lilyminium