-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to importlib resources #4056
Conversation
Following out of self-interest as I need to make parallel changes in a few places
There's also https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.as_posix |
So this code won't work with py3.8. There are ways to make it backwards compatible with py3.8, but honestly given that NEP29 means we ditch py3.8 on the 14th of April, I would suggest just pushing the 2.5.0 release until then and using the modern API for dealing with resources? |
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #4056 +/- ##
========================================
Coverage 93.61% 93.61%
========================================
Files 192 192
Lines 25146 25146
Branches 4058 4058
========================================
Hits 23540 23540
Misses 1089 1089
Partials 517 517 ☔ View full report in Codecov by Sentry. |
Spurious codecov failure aside - this seems to be working fine now. @MDAnalysis/coredevs can I get a couple of extra eyes on a final review here please? This is critical for 2.5.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to you and sed
!
Fixes #4055
Still some work to be done here (mostly getting rid of
__all__
and transferring the information across), but I thought I'd get this in now and let folks comment early since this one is likely to be contentious.Notes:
str
calls (there's probably a nicer way to do this, I spent all of ~ 10 mins on this).PR Checklist