Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected PR, minor fix and resolves #74 #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cerebis
Copy link

@cerebis cerebis commented Sep 12, 2023

In trying the latest master, I found two minor issues.

  1. when getting the latest GTDB release files, the os package needed to be imported within download.py.
  2. when running in contig mode, there was an referenced before assignment error regarding the variable log_file. This happens when certain arguments are supplied, as the logic did not encompass all possibilities.

The command line causing the error follows. I have left the shell variable substitutions in place, but these were initialised.

./CAT/CAT_pack/CAT contigs --tmpdir /scratch/$USER -n 50 -t cat_gtdb_db/tax -d cat_gtdb_db/db -c ${CTG} -o ${OUTBASE}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant