Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Text input example use cases and e2e tests #226

Open
wants to merge 3 commits into
base: mlh-fellowship-migrated-ui-changes
Choose a base branch
from
Open

Implement Text input example use cases and e2e tests #226

wants to merge 3 commits into from

Conversation

manyaagarwal
Copy link

Summary

Add use cases and e2e tests for all props in Textinput component

Changelog

  1. Delete existing separate files for iOS and android
  2. Create one common file which separates use cases based on the platform property
  3. Add a 'magnify.png` file for inlineImage example
  4. Add e2e tests

Test Plan

@manyaagarwal manyaagarwal changed the title Text input example use cases Implement Text input example use cases and e2e tests Aug 18, 2020
@manyaagarwal manyaagarwal added the Final The PR that will be pointed to the facebook repo. Do not delete this branch. label Aug 18, 2020
chirag-singhal and others added 2 commits August 18, 2020 18:10
@chirag-singhal
Add documentation URL to examples and remove community screens (#224)
026bad2 
* add documentationURL to example screens

* remove community package screens

* delete masked view iOS example
@anku255
Merge branch 'mlh-fellowship-migrated-ui-changes' into exmaples/text-…
48d6f3b 
…input
anku255
anku255 approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@anku255 anku255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I have fixed the merge conflicts and also verified that the tests are passing. Here is the screenshot -

Screenshot 2020-08-19 at 11 40 57 AM

@manyaagarwal manyaagarwal added the RNTester The issues associated with the RNTester project. label Aug 19, 2020
@anku255 anku255 force-pushed the mlh-fellowship-migrated-ui-changes branch from b7ebb69 to b2d4f49 Compare August 20, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anku255 anku255 anku255 approved these changes

@YashKumarVerma YashKumarVerma YashKumarVerma approved these changes

Assignees
No one assigned
Labels
Final The PR that will be pointed to the facebook repo. Do not delete this branch. RNTester The issues associated with the RNTester project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manyaagarwal @YashKumarVerma @anku255 @chirag-singhal