Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving build error by updating schema - "relation xxx does not exist" #66

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

mit2400
Copy link
Contributor

@mit2400 mit2400 commented May 4, 2022

Hi,
Thanks for maintaining this repo.

It helped many people working on MIMIC-related research, and still many people are using it.
However, it looks like that MIT-LCP has changed their view generation code to create concepts in the public schema, not the mimiciii schema.

Due to a schema change, people are facing build error as query cannot find generated concepts.

#65 relation "mimiciii.ccs_dx" does not exist
#18 Getting "relation "icustay_detail" does not exist" when running make build_curated_from_psql

Adding option --psql_schema_name public,mimic does not solve the problem because there are queries with hard-coded schema.

  • As a solution, I simply add public schema to search path of codes and queries.

I've tested build instructions and it worked fine.
Hopefully, this will help people struggling with error and not to make this repo outdated.

@mmcdermott
Copy link
Collaborator

Hi @mit2400 -- many of these changes look great, but it seems there is some extra stuff in this PR as well (the focal loss implementation, some imputation functions, etc.). If you want to submit those too, can you separate them into another PR?

@mit2400
Copy link
Contributor Author

mit2400 commented Oct 20, 2022

Hi, @mmcdermott
I have removed changes that are not related to this PR.
Please check if it's okay.

@mmcdermott mmcdermott merged commit d8d2dea into MLforHealth:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants