-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to MpasConfigParser
for config options
#873
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some namelist options are not finding the correct option because of confusions between these names.
This is for consistency with other code
TestingI ran the test suite on Anvil. All tests finished successfully. Results are here: |
While there is certainly room for additional testing, I plan for that to happen before the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge switches to using the
MpasConfigParser
from MPAS-Tools (MPAS-Dev/MPAS-Tools#460). This class has functionality that will be useful in MPAS-Analysis and compass, as well as potentially other tools in the future. The new functionality in MPAS-Analysis is that comments are preserved in the config file written out to the HTML directory and that there is an additional "source" comment for each config option telling the user where it came from. This should hopefully help folks to better understand how config options are built up from multiple sources.Some significant refactoring of the code was required. The
getWtihDefault()
method is not available inMpasConfigParser
, as that has proved to be confusing. It is better to have a default value for the config option indefault.cfg
than hidden in the code. A few defaults were missing and have been added todefault.cfg
.The method
getExpression()
has been renamed togetexpression()
to be more consistent with other methods in the config parser (getint()
,getboolean()
, etc.).