Fix config options for reference-year climatologies

[xylar]

The start and end year for reference climatologies were getting overridden by the user's specified start and end year for normal climatologies.

(This maybe suggests that we should consider a different strategy for setting the start and end years and dates for reference climatologies that doesn't rely on overriding the user config options.)

This fixes issues where the OHC anomaly plots were exactly zero.

closes #883

[xylar]

Testing

The Anvil test suite is currently running. Results are coming in here:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/anvil/fix_ohc_map/

Indications are that the OHC maps are now fixed:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/anvil/fix_ohc_map/main_py3.9/ocean/deltaOHC_0-10000m_main_py3.9_ANN_years0003-0008.png

Update: all analysis in the suite completed and the OHC anomaly map looks like it should in all analysis.

[xylar]

@darincomeau, this is now ready for you to try out and review. You are correct that the bug was introduced in #873.

[darincomeau]

@xylar I reran an existing analysis with the --purge flag, and while the actual png files are populated, the thumbnails still appear blank. I see in your link above the thumbnails are populated, so I'm not sure what happened with my test? I'll try another run to see if that behavior is reproduced:

Thumbnails: https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.dcomeau/20220706.CRYO1850.ne30pg2_SOwISC12to60E2r4.chrysalis.CryoBranchN2DependentDefaultMinMaxKappa/yrs91-100/ocean/index.html#global_ohc_anom

PNG:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.dcomeau/20220706.CRYO1850.ne30pg2_SOwISC12to60E2r4.chrysalis.CryoBranchN2DependentDefaultMinMaxKappa/yrs91-100/ocean/index.html#global_ohc_anom&gid=6&pid=1

[xylar]

@darincomeau, the purge may not be deleting the html directory. Could you try deleting it manually?

[xylar]

Actually, the thumbnail looks right to me. I think if you do shift-F5 or the Mac equivalent in your browser, you'll find that it's just your browser caching the old thumbnail and if you force it to update it will be correct.

[darincomeau]

Ah yes, that did it - thanks!

[darincomeau]

Approved based on above testing.

[xylar]

Thanks @darincomeau!

[alicebarthel]

Great! Thanks @xylar and @darincomeau , that's very helpful!