Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSNAP Arctic Transects transport time series #910

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

anirban89
Copy link
Collaborator

@anirban89 anirban89 commented Sep 27, 2022

Add Arctic Transects from branch https://github.com/milenaveneziani/geometric_features/tree/flipOSNAP_renameArcticTransectsTag of geometric features.
Separate all arctic transects from standard transects using transectGroup flag in config option timeSeriesTransport.
When running mpas_analysis without the flag --polar_regions only standard transects are plotted. All Arctic transects including the three new ones "Hudson Bay-Labrador Sea", "OSNAP section East" and "OSNAP section West"
are only plotted when --polar_regions is specified.
timeSeriesTransport split into transportGroups "Transport Transects" and "Arctic Transport Transects". By default all Arctic transects are removed from standard transects.

User can specify the list of standard transects to plot with transectsToPlot under config option (default.cfg) timeSeriesTransportTransects and leave it as all under timeSeriesArcticTransportTransects. List can not include an Arctic Transect.
Similarly user can also specify the list of arctic transects to plot with transectsToPlot under config option timeSeriesArcticTransportTransects but to plot these mpas_analysis needs to be run with the --polar_regions flag.

Files changed: default.cfg, polar_regions.cfg and ocean/time_series_transport.py
@xylar @milenaveneziani @alicebarthel

@xylar
Copy link
Collaborator

xylar commented Sep 28, 2022

@anirban89, I think this still has the default title from the name of the branch. Could you change it to be a little more informative?

@xylar
Copy link
Collaborator

xylar commented Sep 28, 2022

This will need MPAS-Dev/geometric_features#185 to be merged, a new release of geometric_features, and MPAS-Analysis to be updated to that new version. This isn't as big a deal as it sounds but I'd like to hold off on that process so we can do a bit more testing of MPAS-Dev/geometric_features#185.

@anirban89 anirban89 changed the title Add osnap voltrans ts Add OSNAP Arctic Transects transport time series Sep 28, 2022
@anirban89
Copy link
Collaborator Author

@xylar yes I agree this PR does not need to be merged right now

@xylar
Copy link
Collaborator

xylar commented Oct 10, 2022

@alicebarthel and @milenaveneziani, we want to add obs. to this. What is the right upper and lower value we should use? Min and max in time?

@xylar xylar self-assigned this Oct 13, 2022
@milenaveneziani
Copy link
Collaborator

@xylar: sorry, I never replied to this. I usually compute a standard deviation from all the obs I have (or get it from previous literature) and then plot that as +-sigma around the mean value. @alicebarthel: what do you think?

@cbegeman
Copy link
Collaborator

cbegeman commented Sep 5, 2024

@xylar I have a commit that adds the observational range to this PR (and I've rebased onto develop). After that, this PR should be ready to merge. How should I proceed? I am not able to push to @anirban89's fork.

e.g., https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.cbegeman/analysis/v3.LR.abrupt-4xCO2_0101/osnap_transport_31-36_obs/ocean/index.html#&gid=2&pid=11

@cbegeman cbegeman force-pushed the add_osnap_voltrans_ts branch from 3f8e0a9 to 59fb7b1 Compare September 11, 2024 17:27
@cbegeman
Copy link
Collaborator

@xylar @milenaveneziani @alicebarthel This is ready for review. I don't think all of you need to review it, just maybe whichever one of you has time and interest.

@xylar
Copy link
Collaborator

xylar commented Sep 12, 2024

I'm running my suite of tests on this now. Thanks for reviving it @cbegeman!

@xylar
Copy link
Collaborator

xylar commented Sep 12, 2024

@alicebarthel
Copy link

Thanks @cbegeman! I probably won't get to it today but hopefully tomorrow.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@alicebarthel alicebarthel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cbegeman, these look great! (the tasks and code, not the sad transports through osnap)
Approving based on visual inspection and a short 10-yr analysis test, provided the minor doc updates that Xylar already pointed at.

@cbegeman
Copy link
Collaborator

@xylar This is ready for you to merge when you get back from vacation.

@xylar xylar merged commit d942a5d into MPAS-Dev:develop Sep 17, 2024
5 checks passed
@xylar
Copy link
Collaborator

xylar commented Sep 17, 2024

Thanks @anirban89, @cbegeman, @alicebarthel and @milenaveneziani!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants