-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Arctic transects tag and flip OSNAP sections #185
Rename Arctic transects tag and flip OSNAP sections #185
Conversation
@xylar: I added the script that I used for doing this. There are some small formatting changes (in the affected geojson features). Please take a look and see if they are ok. Thanks. |
feature_creation_scripts/transport_transects/flipOSNAP_renameArcticTransectsTag.py
Show resolved
Hide resolved
feature_creation_scripts/transport_transects/flipOSNAP_renameArcticTransectsTag.py
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think we should test it in MPAS-Analysis, though, before we merge.
@milenaveneziani, we probably need to add an aggregator like this one: Do you want to include that in this PR, too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I'd like to make sure it works well with MPAS-Dev/MPAS-Analysis#910 at least and maybe other MPAS-Analysis branches before we merge.
This does two things:
arctic_sections
tag toarctic_transport_sections
to make it consistent withstandard_transport_sections
, and also as a reminder that the associated geometric features are mostly used for integrated transport calculations;