Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fortran only flag from LDFLAGS_DEBUG for NVIDIA compiler targets #1174

Merged
merged 1 commit into from
May 30, 2024

Conversation

gdicker1
Copy link
Collaborator

The -Mchkptr flag is only valid for Fortran compilation. If included in a C build with NVHPC compilers (like the check with openacc.c does), the build fails.

Before this change, builds using the nvhpc target and OPENACC=true and DEBUG=true would fail. Removing -Mchkptr allows successful debug openacc builds.

The -Mchkptr flag is only valid for Fortran compilation. If included in
a C build with NVHPC compilers (like the check with openacc.c does), the
build fails.
@gdicker1
Copy link
Collaborator Author

The build of openacc.c occurs as part of the openacc_test target in the top-level Makefile. Without this change, builds fail around line 1123 of the top-level Makefile (before any actual MPAS files are touched).

User's would then have to compile the openacc.c program (as directed by the build) to see the error message related to -Mchkptr.

@mgduda
Copy link
Contributor

mgduda commented May 29, 2024

@gdicker1 Just a note for similar PRs in future, since the changes are in the top-level Makefile and not specific to MPAS-Atmosphere a branch name with framework/ rather than atmosphere/ may be preferable. But no worries for this PR!

@mgduda mgduda self-requested a review May 29, 2024 16:53
@gdicker1
Copy link
Collaborator Author

@gdicker1 Just a note for similar PRs in future, since the changes are in the top-level Makefile and not specific to MPAS-Atmosphere a branch name with framework/ rather than atmosphere/ may be preferable. But no worries for this PR!

Thanks for the reminder!

@mgduda mgduda merged commit d6e56eb into MPAS-Dev:develop May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants