Add OpenACC module to core_test #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also includes changes to LDFLAGS that are in #1174. |
gdicker1
changed the title
mgduda
requested changes
May 31, 2024
gdicker1
force-pushed
the
framework/openacc_test
branch
from
b5d2a99 to
690909e
Compare
gdicker1
force-pushed
the
framework/openacc_test
branch
2 times, most recently
from
10fb55b to
cdc2ac0
Compare
mgduda
requested changes
May 31, 2024
gdicker1
force-pushed
the
framework/openacc_test
branch
from
cdc2ac0 to
054078d
Compare
mgduda
requested changes
May 31, 2024
There was a problem hiding this comment.
The final state of the PR branch looks good to me. But, some commits (e.g., a2a82b2) don't compile with the GNU 13.2.0 compilers:
mpas_test_openacc.F:343:10:
343 | #ifdef MPAS_OPENACC
| 1
Error: Invalid character in name at (1)
If it's easier, feel free to just squash all of the commits into a single commit. Otherwise, if you'd like to preserve all commits, I think you may need to go back to the first commit on the branch to resolve the pre-processing directive issue.
Right now this just contains a stub routine, but this gets some of the "plumbing work" done.
Guard the call to mpas_test_openacc routine with ifdef MPAS_OPENACC so the routines are only run if the test_core is built with OpenACC enabled.
This test carries out some calculations on the CPU and the GPU based on patterns in the dynamics of core_atmosphere. If the difference between the CPU results and the GPU results is 0, the test succeeds.
gdicker1
force-pushed
the
framework/openacc_test
branch
from
054078d to
b276568
Compare
mgduda
approved these changes
May 31, 2024
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new module to the test core that will be used to test OpenACC functionality and any OpenACC-specific framework routines that are added to MPAS. The only test added in this PR is based on patterns from the MPAS-A dycore. If the test core is compiled without
OPENACC=true, the OpenACC tests are skipped.